Improve emitter send data log - #343
Merged
Merged
Conversation
…r of bytes involved and the type of entity that failed to be published. New log message has format: Exception while sending segment (SegmentImpl) over UDP for entity CoreApi [1827010d1fe3a482] on segment [no parent segment]. Bytes: 77861
…r of bytes involved and the type of entity that failed to be published. New log message has format: Exception while sending segment (SegmentImpl) over UDP for entity CoreApi [1827010d1fe3a482] on segment [no parent segment]. Bytes: 77861
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #343 +/- ##
============================================
- Coverage 58.96% 58.95% -0.02%
Complexity 1207 1207
============================================
Files 131 131
Lines 5064 5065 +1
Branches 592 592
============================================
Hits 2986 2986
- Misses 1805 1806 +1
Partials 273 273 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wangzlei
approved these changes
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#26
Description of changes:
Improve the emitter sendData failure log message to include the number of bytes involved and the type of entity that failed to be published.
New log message has format:
This code semi-frequently publishes a semi-meaningless stack trace
java.net.SocketException: Message too longwhen the UDP packet to the daemon server is too large.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.