Skip to content

updated spring dependencies #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhautikpip merged 1 commit into from
Apr 4, 2022
Merged

updated spring dependencies #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions aws-xray-recorder-sdk-spring/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ dependencies {
api("org.aspectj:aspectjrt:1.8.11")

// TODO(anuraaga): Remove most of these? Seems only Configurable annotation is used

@srprash srprash Apr 4, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anuraaga 's comment hints that these dependencies could be removed. If it is not a big effort, maybe this is a good time to do so?
Otherwise LGTM.

@bhautikpip bhautikpip Apr 4, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah Good callout. I think it's a small change relatively but in order to ensure nothing breaks and SDK works as expected we might need to do some additional testing so I have scoped that work out of this PR if that makes sense.

implementation("org.springframework:spring-context-support:4.3.12.RELEASE")
implementation("org.springframework:spring-context:4.3.12.RELEASE")
implementation("org.springframework:spring-aspects:4.3.12.RELEASE")
implementation("org.springframework:spring-context-support:5.3.18")
implementation("org.springframework:spring-context:5.3.18")
implementation("org.springframework:spring-aspects:5.3.18")

compileOnly("org.springframework.data:spring-data-commons:2.0.0.RELEASE")
compileOnly("org.springframework.data:spring-data-commons:2.6.3")
}

tasks.jar {
Expand Down