added mechanism to set log group via env var - #273
Merged
Conversation
anuraaga
approved these changes
Apr 6, 2021
| logger.info("Recording log group " + logGroupFromEnv + " from environment variable."); | ||
| AWSLogReference logReference = new AWSLogReference(); | ||
| logReference.setLogGroup(logGroupFromEnv); | ||
| Set<AWSLogReference> logReferences = new HashSet<>(); |
Contributor
There was a problem hiding this comment.
Think you can use something like Collections.singleton
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
============================================
+ Coverage 59.46% 59.52% +0.06%
- Complexity 1207 1210 +3
============================================
Files 131 131
Lines 5040 5048 +8
Branches 585 586 +1
============================================
+ Hits 2997 3005 +8
Misses 1770 1770
Partials 273 273
Continue to review full report at Codecov.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #273 +/- ##
============================================
+ Coverage 59.46% 59.63% +0.16%
- Complexity 1207 1210 +3
============================================
Files 131 131
Lines 5040 5046 +6
Branches 585 586 +1
============================================
+ Hits 2997 3009 +12
+ Misses 1770 1764 -6
Partials 273 273 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Simple addition to allow customers to set a custom value for a log group via the
AWS_LOG_GROUPenvironment variable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.