Add option to always create trace ID - #243
Merged
Merged
Conversation
willarmiros
reviewed
Nov 30, 2020
willarmiros
left a comment
willarmiros
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this contribution! LGTM overall, just a naming change recommendation as requested.
| * This could be useful for example in case the Trace ID is logged to be able to aggregate all logs from a | ||
| * single request | ||
| */ | ||
| public AWSXRayRecorderBuilder withAlwaysCreateTraceId() { |
Contributor
There was a problem hiding this comment.
I think withForcedTraceIdGeneration would sound better.
| * Configures this {@code AWSXRayRecorder} to add valid TraceId in all segments even NoOp ones that usually have | ||
| * a fixed value. | ||
| */ | ||
| public void alwaysCreateTraceID(final boolean alwaysCreateTraceId) { |
Contributor
There was a problem hiding this comment.
It would probably be best if this method was explicitly named as a setter, e.g. setForcedTraceIdGeneration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #238
Description of changes:
This PR adds a new method in the builder and in the recorder to force NoOpSegments to have a valid individual Trace ID.
I am not entirely happy with the variable name so suggestions are accepted.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.