Skip to content

Apply checkstyle and prepare for license header check. - #156

Merged
anuraaga merged 7 commits into
aws:masterfrom
anuraaga:license-plugin
Jun 2, 2020
Merged

Apply checkstyle and prepare for license header check.#156
anuraaga merged 7 commits into
aws:masterfrom
anuraaga:license-plugin

Conversation

@anuraaga

@anuraaga anuraaga commented Jun 1, 2020

Copy link
Copy Markdown
Contributor

This applies Gradle plugins to apply license header and checkstyle. License header and IntelliJ / checkstyle config are copied from the AWS SDK.

Most code changes are license addition and whitespace. Sometimes, I cleaned up code that otherwise would cause checkstyle to fail, e.g.,

  • private ObjectMapper mapper = ... -> private static final ObjectMapper MAPPER =
  • Deprecate utility classes without a private constructor. While it's really unlikely that users call them, it's not impossible so we should fix in a major release. As these utilities are for the SDK they should be internal anyways so just went ahead and deprecated them. We'll probably deprecate a lot more stuff that users probably don't use in an effort to reduce surface for v3.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@willarmiros willarmiros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending approval for licensing plugin, which should be granted without issue.

@willarmiros willarmiros closed this Jun 2, 2020
@willarmiros willarmiros reopened this Jun 2, 2020
@anuraaga

anuraaga commented Jun 2, 2020

Copy link
Copy Markdown
Contributor Author

Thanks - while waiting on the license plugin, I went ahead and disabled it for now. Enabling license is quite simple and automated while checkstyle is much harder so will go ahead and merge just that in for now to prevent drift.

@anuraaga anuraaga changed the title Apply license header and checkstyle Apply checkstyle and prepare for license header check. Jun 2, 2020
@anuraaga
anuraaga merged commit 4528f39 into aws:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants