Apply checkstyle and prepare for license header check. - #156
Merged
Conversation
willarmiros
approved these changes
Jun 1, 2020
willarmiros
left a comment
Contributor
There was a problem hiding this comment.
Approved pending approval for licensing plugin, which should be granted without issue.
Contributor
Author
|
Thanks - while waiting on the license plugin, I went ahead and disabled it for now. Enabling license is quite simple and automated while checkstyle is much harder so will go ahead and merge just that in for now to prevent drift. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies Gradle plugins to apply license header and checkstyle. License header and IntelliJ / checkstyle config are copied from the AWS SDK.
Most code changes are license addition and whitespace. Sometimes, I cleaned up code that otherwise would cause checkstyle to fail, e.g.,
private ObjectMapper mapper = ...->private static final ObjectMapper MAPPER =By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.