Minor cleanups of equals and hashcode in core - #142
Merged
Conversation
willarmiros
approved these changes
May 11, 2020
willarmiros
left a comment
willarmiros
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the improvements!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a starter PR with some cleanups as I get to know the repo better :) In particular, I noticed the patterns were mixed within the module so this makes them consistent too.
Description of changes:
Use
hashCodemethod instead ofObjects.hash. The later has poor performance because it allocates a varargs array even for this single argumentinstanceofinstead ofgetClass() ==. Java 8+, which the module targets, performs better withinstanceof, and the code is a bit cleaner to boot thanks to automatic null check.getClasscould still be appropriate where a subclass really has to match a subclass, but this doesn't seem to be intendedObject.equalsinstead of a tree ofnullchecksBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.