fix(core): resolveReferences should only update references that require updates on its second pass in nested stacks - #38813
Draft
ShadowCat567 wants to merge 1 commit into
Draft
fix(core): resolveReferences should only update references that require updates on its second pass in nested stacks#38813ShadowCat567 wants to merge 1 commit into
resolveReferences should only update references that require updates on its second pass in nested stacks#38813ShadowCat567 wants to merge 1 commit into
Conversation
Contributor
|
PRs without a linked issue will receive lower priority for review and merging. Please update the description to follow the PR template and include a line like |
aws-cdk-automation
requested changes
Sep 11, 2026
aws-cdk-automation
left a comment
Collaborator
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
When we synthesize an app with nested stacks, we do two passes of
resolveReferenceswhich is an expensive operation that walks the construct tree and resolves all the tokens it finds.We do not need to resolve tokens in every construct in the construct tree a second time after setting up our nested stack assets. We should only revisit the constructs that received nested stack assets and do a second pass resolve on them instead of doing a second pass resolve on the entire stack.
Description of changes
We have a new function
resolveReferencesInElementswhich will resolve all references in a given construct. This is used byresolveReferenceswhich passes it a DFS iterator which goes through all the constructs in the construct tree. This is also directly invoked on all of the nested stacks, instead of starting from the root of the construct tree (like we did previously).Describe any new or updated permissions being added
N/A
Description of how you validated changes
Added new tests to ensure we are not missing any cross stack references and ensured current tests relating to nested stacks still pass.
When I tested on a stack with a lot of nested stacks I saw the time taken by the second resolve pass after
defineNestedStackAssetdrop from 3,404ms to 35ms.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license