Skip to content

docs(ec2): clarify RouterType.GATEWAY supports Virtual Private Gateway - #38358

Closed
wasim-builds wants to merge 0 commit into
aws:mainfrom
wasim-builds:fix/ec2-routertype-gateway-doc
Closed

docs(ec2): clarify RouterType.GATEWAY supports Virtual Private Gateway#38358
wasim-builds wants to merge 0 commit into
aws:mainfrom
wasim-builds:fix/ec2-routertype-gateway-doc

Conversation

@wasim-builds

@wasim-builds wasim-builds commented Jul 21, 2026

Copy link
Copy Markdown

Closes #38358

Summary

Clarify that RouterType.GATEWAY supports Virtual Private Gateway (VGW) attachments in the EC2 VPN module.

Problem

The documentation for RouterType.GATEWAY did not explicitly mention VGW support, leading to confusion about whether classic VPN gateways could be used with this router type.

Fix

Updated the doc comment to explicitly state VGW compatibility.

Scope

Documentation-only change in EC2 VPN module. No runtime behavior changes.

@github-actions github-actions Bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jul 21, 2026
@aws-cdk-automation
aws-cdk-automation requested a review from a team July 21, 2026 15:36
@wasim-builds
wasim-builds force-pushed the fix/ec2-routertype-gateway-doc branch from 88c20a3 to 1272cc3 Compare July 21, 2026 16:19
@wasim-builds
wasim-builds force-pushed the fix/ec2-routertype-gateway-doc branch from 1272cc3 to 3e4c5cd Compare July 23, 2026 15:03
@mergify

mergify Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

⚠️ The sha of the head commit of this PR conflicts with #38357. Mergify cannot evaluate rules on this PR. Once #38357 is merged or closed, Mergify will resume processing this PR. ⚠️

@wasim-builds

Copy link
Copy Markdown
Author

Rebased onto latest upstream/main. No other changes.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ The following issue reference(s) in your PR description are not valid issues:

Please make sure your PR references an existing issue using the format Closes #123.

@wasim-builds
wasim-builds force-pushed the fix/ec2-routertype-gateway-doc branch from 7b3e709 to 74d922c Compare August 19, 2026 11:06
Copilot AI lite review requested due to automatic review settings August 19, 2026 11:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 19, 2026
@mergify
mergify Bot deployed to automation August 19, 2026 11:22 Active
@mergify
mergify Bot deployed to automation August 19, 2026 11:23 Active
@mergify
mergify Bot deployed to automation August 19, 2026 11:23 Active
@mergify
mergify Bot deployed to automation August 19, 2026 11:23 Active
@mergify
mergify Bot deployed to automation August 19, 2026 11:23 Active
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants