fix(dynamodb): remove deprecated tablegrants props from tablev2 - #38184
fix(dynamodb): remove deprecated tablegrants props from tablev2#38184josemfche wants to merge 4 commits into
Conversation
Fixes aws#37221 Remove deprecated encryptedResource and policyResource from TableGrants initialization in TableV2 and TableV2MultiAccountReplica. TableGrants already auto-discovers encryption keys and resource policies when omitted. Add regression tests for the jsii compiled path and DynamoEventSource grant behavior.
Add integ test covering TableV2 with DynamoEventSource to satisfy PR linter for Fixes aws#37221.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Integration snapshot note for maintainers: The When adding cd packages/@aws-cdk-testing/framework-integ
yarn integ --force aws-lambda-event-sources/test/integ.dynamodb-table-v2.jsLocal snapshot verification passes ( |
|
This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing To prevent automatic closure:
This PR will automatically close in 14 days if no action is taken. |
Fixes #37221
Summary
Removes deprecated
encryptedResourceandpolicyResourceprops fromTableGrantsinitialization inTableV2andTableV2MultiAccountReplica.TableGrantsalready auto-discovers encryption keys and resource policies viaEncryptedResources.of()/ResourceWithPolicies.of()when those props are omitted.This stops JSII deprecation warnings triggered by the
"encryptedResource" in pcheck even when the values areundefined.Test plan
table-v2-base.test.tscovering:DynamoEventSourcestream grants preservedgrantReadDatastill grants KMS via auto-discoveryyarn test aws-dynamodb/test/ --coverage=false— 413/413 passedMade with Cursor