fix(ecs): enabling the circuitBreaker is not recommended loudly enough - #37755
Conversation
If a simple misconfiguration in an ECS Task Definition causes the task to never start, a Service based off of that Task Definition takes 3 hours to fail unless `circuitBreaker` is configured. This is not obvious: our examples don't show that and the construct itself never tells you about it. Update our top-level README example to include the circuit breaker field, and make the construct warn you if you didn't configure the property (you most likely always want it).
|
PRs without a linked issue will receive lower priority for review and merging. Please update the description to follow the PR template and include a line like |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status
This pull request spent 1 hour 39 minutes 37 seconds in the queue, including 31 minutes 56 seconds running CI. Required conditions to merge
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
If a simple misconfiguration in an ECS Task Definition causes the task to never start, a Service based off of that Task Definition takes 3 hours to fail unless
circuitBreakeris configured.This is not obvious: our examples don't show that and the construct itself never tells you about it.
Update our top-level README example to include the circuit breaker field, and make the construct warn you if you didn't configure the property (you most likely always want it). Also remove
desiredCapacityfrom the initial example, which is not recommended anymore because setting that unscales your service during deployments (it even warns).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license