refactor(metrics): rename option property from raiseOnEmptyMetrics to throwOnEmptyMetrics

[kozub]

Description of your changes

How to verify this change

Make sure that all existance of "raiseOnEmptyMetrics" were renamed.

Related issues, RFCs

#348

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

• My changes meet the tenets criteria
• I have performed a self-review of my own code
• I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• The code coverage hasn't decreased
• I have added tests that prove my change is effective and works
• New and existing unit tests pass locally and in Github Actions
• Any dependent changes have been merged and published in downstream module
• The PR title follows the conventional commit semantics

Breaking change checklist

• I have documented the migration process
• I have added, implemented necessary warnings (if it can live side by side)

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[dreamorosi]

Thanks a lot for your first contribution @kozub!

[dreamorosi]

Left some minor comments & suggestions but looking forward to approve this!

[kozub]

Hey @dreamorosi! Thanks for your suggestions. I've added second commit with your comments applied. Please let me know if you prefer to have all that changes as single commit - I can squash it before mering. I'm not sure what's your preference for this repo.

[dreamorosi]

Looks good to me, thanks for applying the changes. Once we have a second review from another maintainer we'll squash on merge!

[ijemmy]

Thanks a lot! This issue has been bugging me but we were too busy with the beta release.

I find 3 more lines. Then we are good to go. (Sorry that examples don't follow the same pattern, we are working on this).

grep -rn -i "raise" . --exclude=\*venv\* --exclude=\*.git\* --exclude=\*node_modules\* --exclude=\*cdk.out\* --exclude=\*.js\* --exclude=\*.d.ts\* --exclude=\*.html\*

./examples/cdk/lib/example-function.MyFunction.ts:32:  metrics.raiseOnEmptyMetrics();
./examples/cdk/lib/example-function.MyFunction.ts:41:  metrics.raiseOnEmptyMetrics();
./examples/cdk/lib/example-function.MyFunctionWithDecorator.ts:18:    raiseOnEmptyMetrics: true,

[kozub]

Hey @ijemmy - I've changed method signatures that you mentioned about. Thanks for finding it! I'd tried to search in the project for 'raise' before using VSCode with no results. Looks that I should not trust it ;-)

[dreamorosi]

Hey @ijemmy - I've changes method signatures that you mentioned about. Thanks for finding it! I'd tried to search in the project for 'raise' before using VSCode with no results. Looks that I should not trust it ;-)

Yea, I did the same and also didn't find them, nice one @ijemmy

[ijemmy]

@kozub No problem. It's the same for me. VSCode seems to miss these.

I had this issue before and never trusted its search function since then.

[ijemmy]

There was a merge conflict. I have merged from main, resolved, and approved.

@dreamorosi Can I have a new approval?