Skip to content

fix(parser): links the error cause with ParseError #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dreamorosi merged 2 commits into from
Jul 15, 2024
Merged

fix(parser): links the error cause with ParseError #2774

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c406e8
fix(parser): adds the cause to the ParseError
tusharf5 Jul 14, 2024
a32a1d0
refactor based on feedback
tusharf5 Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/parser/src/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ class ParseError extends Error {
? `${message}. This error was caused by: ${options?.cause.message}.`
: message;
super(errorMessage);
this.cause = options?.cause;
Comment thread
dreamorosi marked this conversation as resolved.
Outdated
this.name = 'ParseError';
}
}
Expand Down
9 changes: 8 additions & 1 deletion packages/parser/tests/unit/envelope.test.ts
View file
Open in desktop
Comment thread
dreamorosi marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { z } from 'zod';
import { z, ZodError } from 'zod';
import { Envelope } from '../../src/envelopes/envelope.js';
import { ParseError } from '../../src/errors.js';

Expand Down Expand Up @@ -74,5 +74,12 @@ describe('envelope: ', () => {
Envelope.parse({ name: 123 }, z.object({ name: z.string() }))
).toThrow();
});
it('the error has the cause attached to it', () => {
Comment thread
dreamorosi marked this conversation as resolved.
Outdated
try {
Envelope.parse('{"name": "John"}', z.object({ name: z.number() }));
} catch (error) {
expect((error as { cause: Error }).cause).toBeInstanceOf(ZodError);
Comment thread
dreamorosi marked this conversation as resolved.
Outdated
}
});
});
});