fix(parser): links the error cause with ParseError - #2774
Merged
Conversation
boring-cyborg
Bot
added
parser
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
Bot
added
do-not-merge
dreamorosi
removed
do-not-merge
dreamorosi
requested changes
Jul 14, 2024
dreamorosi
left a comment
dreamorosi
left a comment
Contributor
There was a problem hiding this comment.
Thank you so much for taking the time to open this PR!
I have left a couple of comments that I think we should address before merging it.
Contributor
Author
|
@dreamorosi Made the changes based on the feedback, thanks. |
dreamorosi
approved these changes
Jul 15, 2024
dreamorosi
left a comment
dreamorosi
left a comment
Contributor
There was a problem hiding this comment.
Thank you for addressing the feedback, merging it!
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
The ParseError links the passed error cause with the thrown error.
Issue number: fixes #2773
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.