I'm submitting a bug report
- Library Version:
Latest (1.0.0-beta.12)
Please tell us about your environment:
-
Operating System:
Windows [10]
-
Node Version:
10.15.0 (also tested 11.8.0)
-
NPM Version:
6.4.1
-
Browser:
N/A (Jasmine test run)
-
Language:
JS
-
Loader/bundler:
N/A
Current behavior:
Given you cloned the cli repo
And performed npm install
When you run npm run test
Then Executed 318 of 318 specs (36 FAILED) in 44 secs.
Failures seem to be related to accessing file system. I've debugged and noticed fs.existsSync throws an error while it should return a boolean. This seems to be a change in behavior in node. Issue can be resolved by wrapping the method in a try/catch block.
-
What is the expected behavior?
Expected all tests to pass on master.
-
What is the motivation / use case for changing the behavior?
I would like to contribute to the cli repo. Unless all tests are green for untouched code I cannot modify code and guarantee its functioning as intended.
I'm submitting a bug report
Latest (1.0.0-beta.12)
Please tell us about your environment:
Operating System:
Windows [10]
Node Version:
10.15.0 (also tested 11.8.0)
NPM Version:
6.4.1
Browser:
N/A (Jasmine test run)
Language:
JS
Loader/bundler:
N/A
Current behavior:
Given you cloned the cli repo
And performed
npm installWhen you run
npm run testThen Executed 318 of 318 specs (36 FAILED) in 44 secs.
Failures seem to be related to accessing file system. I've debugged and noticed fs.existsSync throws an error while it should return a boolean. This seems to be a change in behavior in node. Issue can be resolved by wrapping the method in a try/catch block.
What is the expected behavior?
Expected all tests to pass on master.
What is the motivation / use case for changing the behavior?
I would like to contribute to the cli repo. Unless all tests are green for untouched code I cannot modify code and guarantee its functioning as intended.