unable to use with prebuild for Electron 4 because of ABI incompatibilities

[Akumzy]

I just I deleted and re-install my node_modules since then I started getting this error
electron version: 4.0.0@beta.1
system: Ubuntu
v8_natives_data:symbol lookup error: /home/akumzy/node_modules/keytar/build/Release/keytar.node: undefined symbol: _ZN2v816FunctionTemplate3NewEPNS_7IsolateEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEENS_5LocalIS4_EENSA_INS_9SignatureEEEiNS_19ConstructorBehaviorE

[dannyseo517]

Same with:
keytar: 4.3.0
electron: 3.0.4
node: 10.2.1
npm: 5.6.0

tested with electron-quick-start.

[kerabromsmu]

I deleted and reinstalled the node_modules, but nothing changed. Electron reports the same error after that

[janis91]

Same here.

I can reproduce this error only when using keytar v4.3.0.
With v4.2.1 it is working regardless of the electron version (3 or 4). Node version 10.

Hope this helps.

[bendemboski]

I can reproduce this error only when using keytar v4.3.0.
With v4.2.1 it is working regardless of the electron version (3 or 4). Node version 10.

I'm pretty sure this is because only 4.3.0 has prebuilt binaries that work with electron 3/4 (ABI version 64). So if you're using 4.2.1, you'll be falling back on building them locally.

So I guess it looks like the problem is not in the source code, but something about how the prebuilt binaries are being built...

[vladimiry]

Facing a similar issue. Though not just with keytar, but with sodium-native too, possibly with all the native modules that go with prebuilts. I ended up for now forcing removing all the prebuilts and then triggering rebuilding from sources.

[bendemboski]

I'm pretty sure I've tracked down the cause of this. It's this bug in node-abi that is making prebuild and prebuild-install think that the same binaries can be used for Electron 3 and Electron 4, when in reality the ABI changed between them.

[shiftkey]

@bendemboski thanks for digging into this. I'll keep an eye on electron/node-abi#55.