fix(tests): relax assertions sensitive to test environment data#2319
Merged
Conversation
Consolidates updates from the following dependency PRs: - #2313: Bump awssdk from 2.42.10 to 2.42.11 - #2315: Bump io.openlineage:openlineage-java from 1.44.1 to 1.45.0 - #2314: Bump actions/download-artifact from v8.0.0 to v8.0.1 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
- admin-export: remove group alias != name invariant; Atlan allows a group's alias to equal its technical name, making this check invalid - adoption-export: guard both testViews methods with an early exit when the Views sheet has no rows (occurs when all viewed assets have since been deleted from the catalog) - adoption-export: remove strict descending-order assertion from ExportUniqueUserViewsTest; Elasticsearch terms aggregations sorted by a cardinality sub-aggregation do not guarantee per-row ordering across shards, making this check non-deterministic Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
cmgrote
enabled auto-merge
March 12, 2026 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assertTrue(row["Groups"] != row["Group names"])— a group's alias is allowed to equal its technical name in Atlan, making this a false invariantExportRawViewsTest): GuardtestViewswith an early exit when the Views sheet has no rows; this occurs when all assets that appear in the search log have since been deleted from the catalogExportUniqueUserViewsTest): Remove the strict descending-order assertion; Elasticsearchtermsaggregations sorted by a cardinality sub-aggregation do not guarantee per-row ordering across shards, making the check non-deterministicTest plan
admin-exportpackage tests (ExportUsersTest)adoption-exportpackage tests (ExportRawViewsTest,ExportUniqueUserViewsTest)🤖 Generated with Claude Code