[ty] Retain typing-only symbols in explicit completions - #27435
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 96.95%. The percentage of expected errors that received a diagnostic held steady at 92.39%. The number of fully passing files held steady at 102/133. |
Memory usage reportMemory usage unchanged ✅ |
|
charliermarsh
marked this pull request as ready for review
August 3, 2026 18:32
charliermarsh
requested review from
AlexWaygood and
MichaReiser
and removed request for
dhruvmanila
August 3, 2026 18:32
charliermarsh
force-pushed
the
charlie/ty-type-only-completion-ranking
branch
from
August 4, 2026 13:36
613c4c9 to
09af803
Compare
charliermarsh
enabled auto-merge (squash)
August 4, 2026 13:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We now exclude private type variables, parameter specifications, type-variable tuples, aliases, and
@type_check_onlydefinitions from completions, even though those names can be explicitly imported in typing-only contexts:This PR makes those definitions consistent with existing
@type_check_onlycompletion behavior: retain them as explicit import and attribute completions, mark them as typing-only, and rank them below runtime values.