[ty] Improve error context for incompatible callable signatures - #27422
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 96.94%. The percentage of expected errors that received a diagnostic held steady at 92.21%. The number of fully passing files held steady at 101/133. |
Memory usage reportMemory usage unchanged ✅ |
|
AlexWaygood
force-pushed
the
alex/signature-context
branch
2 times, most recently
from
August 2, 2026 20:54
f7e3afc to
65426a6
Compare
AlexWaygood
commented
Aug 2, 2026
| info: the first parameter is missing | ||
| ``` | ||
|
|
||
| ## Missing parameters in nested generic calls involving `TypeVarTuple`s and `ParamSpec`s |
Member
Author
There was a problem hiding this comment.
these regression tests are added because an earlier version of the PR accidentally added subdiagnostics that were confusing/incorrect for these cases, which are meant to be out of scope for this PR
AlexWaygood
force-pushed
the
alex/signature-context
branch
from
August 2, 2026 20:58
65426a6 to
ba9fe0f
Compare
AlexWaygood
force-pushed
the
alex/signature-context
branch
from
August 2, 2026 21:01
ba9fe0f to
29c7c61
Compare
AlexWaygood
marked this pull request as ready for review
August 2, 2026 21:02
charliermarsh
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We had a lot of branches in
signatures.rswhere we were failing to add error context, which often made our diagnostics less comprehensible than they could have been. This PR adds context to lots of these branches, and adds snapshots to cover the new code paths.There are still lots of
return self.never();branches, even on this PR branch, that don't have any error context attached to them. I was too scared to touch theParamSpec- andTypeVarTuple-specific branches in this PR 🙈 so left them out of scope for now.