[ty] Introduce shared primitives for parsing backticks in docstrings - #26928
Merged
Conversation
lerebear
force-pushed
the
lerebear/push-krurnqpmzmum
branch
11 times, most recently
from
July 22, 2026 22:40
9593c21 to
4436ab1
Compare
lerebear
force-pushed
the
lerebear/push-krurnqpmzmum
branch
from
July 23, 2026 03:57
4436ab1 to
cd9fb36
Compare
lerebear
marked this pull request as ready for review
July 23, 2026 05:10
MichaReiser
approved these changes
Jul 23, 2026
MichaReiser
left a comment
Member
There was a problem hiding this comment.
Nice.
Codex claims that the backtick lexer is overly strict and doesn't correctly recover from invalid backticks
`unmatched ``code``should be
vec![
("text", "`unmatched "),
("span", "code"),
]
Escaping only escapes the first backtick, not all of them
\``code`Expected
vec![
("text", r"\`"),
("span", "code"),
]
lerebear
force-pushed
the
lerebear/push-krurnqpmzmum
branch
2 times, most recently
from
July 23, 2026 22:23
7a81c3f to
b78da19
Compare
lerebear
force-pushed
the
lerebear/push-krurnqpmzmum
branch
from
July 23, 2026 22:48
b78da19 to
05178ee
Compare
Contributor
Author
Those findings are both accurate, but I don't think they're worth fixing at the moment:
Of course we can readjust in the future if we receive complaints. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This refactors the code span parsing we do in docstrings around a cursor-based scanner and explicit ranged backtick runs and spans. Ultimately, this serves two purposes:
Test plan
See included tests.