Allow human-readable names in rule selectors by ntBre · Pull Request #25887 · astral-sh/ruff

ntBre · 2026-06-11T22:00:45Z

Summary

This PR enables using rule names as selectors in preview by also attempting to parse a selector as a human-readable name in UnresolvedRuleSelector::resolve. If this succeeds and preview is enabled, the rule is activated, and if preview is disabled you get a custom error message.

Test Plan

A few new CLI tests. I figured the tests from #26113 cover the shared behavior for the other selectors well enough and just focused on select as an example for both the CLI and config file.

astral-sh-bot · 2026-06-11T22:11:56Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

MichaReiser

I'm leaning towards splitting this PR and I even suggest to go one step further than what you did, by fully deferring rule parsing.

ty accepts all rule names on the CLI or in configurations. They're only validated when turning the configuration into a settings struct and ty emits a warning for every unknown rule.

#14443 is a ruff issue that asks for the same.

That's why I wonder what it would mean if we fix #14443 first by using an UnresolvedRuleName(String, source?) and only parse the rule to a RuleSelector in into_settings. I believe this should also allow you to merge the RuleSelector::Rule variants again.

Do you want to give this a try. I'm sure there's something that will make this unreasonably hard :)

ntBre · 2026-06-15T13:59:13Z

Sure, I can give that a try!

Summary -- This PR fixes #14443 by deferring rule parsing. This allows deserializing configuration files and CLI arguments with unknown rule selectors and enables us to emit a warning instead of a hard error when encountering an unknown selector. This will also help with #25887 because we can also defer parsing until we have an accurate `preview` setting for checking whether human-readable names should be allowed. I've left some of this infrastructure in place in this PR, with the `preview` argument currently unused. Test Plan -- Existing tests updated to show warnings instead of errors

check preview in other cases warn everywhere test all the flags tidy link to this pr on preview feature the per-file-ignore changes especially should be fully reverted

ntBre · 2026-06-24T20:33:09Z

This is not strictly necessary, it just gives a nicer conversion than this awkward parsing round trip from the previous commit:

ruff/crates/ruff_linter/src/rule_selector.rs

Lines 26 to 28 in ff5b9cd

if is_human_readable_names_enabled(preview) {

return Ok(RuleSelector::from_str(&rule.noqa_code().to_string()).unwrap());

}

ntBre · 2026-06-24T20:34:08Z

+When [preview mode](preview.md) is enabled, rule selectors also accept the human-readable name of a
+rule (e.g., `unused-import`).


Codex wanted to make this much more prominent in the CLI and other docs, but I thought that seemed a bit premature and that this was a better starting point.

MichaReiser

Nice, this looks much "simpler" now.

I suggest we change RuleSelector::Rule to store a rule now, where we already resolve it anyway.

Do we need to update options.rs and mention that human-readable names are now accepted in many places under preview?

MichaReiser · 2026-06-25T06:00:57Z

+        let prefix = get_prefix_ident(&code.value());
+        rule_selector_match_arms.extend(quote! {
+            #(#attrs)* Rule::#rule_name => RuleCodePrefix::#linter(#linter::#prefix),
+        });


Instead of adding another match over all codes, could we change RuleSelector::Rule to store a Rule instead? I'm not sure what the reason was originally for storing only the selector prefix. But it might just have been because we used RuleSelector for deserialization, which we now no longer do.

Yeah, this was very doable. Thanks!

MichaReiser · 2026-06-25T06:03:42Z

+
+    ----- stderr -----
+    ruff failed
+      Cause: Rule name `unused-import` used as selector with preview disabled in `select` from [TMP]/ruff.toml


Suggested change

Cause: Rule name `unused-import` used as selector with preview disabled in `select` from [TMP]/ruff.toml

Cause: Rule name `unused-import` used as selector with preview disabled in `select` from `[TMP]/ruff.toml`

MichaReiser · 2026-06-25T06:08:32Z

+
+    ----- stderr -----
+    ruff failed
+      Cause: Rule name `unused-import` used as selector with preview disabled in `select` from the CLI


I find this a bit hard to understand. Maybe something like? Invalid --select unused-import. Selecting rules by their name requires enabling preview mode.

I like the look of --select unused-import, but I don't think we can use --select since we also consider --config select=... as coming from the CLI. I like moving the preview part to the end, though. I went with:

Invalid selector `unused-import` in `select` from the CLI. Selecting rules by name requires preview mode

ntBre · 2026-06-25T14:37:06Z

Do we need to update options.rs and mention that human-readable names are now accepted in many places under preview?

As I mentioned in my review comment, I thought it might be better to leave this out for now in favor of the single linter.md callout since it requires a lot of awkward "in preview" phrasing. I'm happy to do it if you prefer, though. I do want users to know about it.

Summary -- I didn't think to rebase #26240 after merging #25887 and there was a conflict in the schema. This should fix the current failure on main. Test Plan -- CI

ntBre added preview Related to preview mode features rule-selection Related to enabling or disabling rules labels Jun 11, 2026

ntBre commented Jun 12, 2026

View reviewed changes

Comment thread crates/ruff_linter/src/settings/types.rs Outdated

ntBre marked this pull request as ready for review June 12, 2026 16:01

ntBre requested a review from MichaReiser June 12, 2026 16:02

MichaReiser reviewed Jun 15, 2026

View reviewed changes

ntBre marked this pull request as draft June 15, 2026 13:59

ntBre mentioned this pull request Jun 17, 2026

Emit a warning instead of an error for unknown rule selectors #26113

Merged

ntBre mentioned this pull request Jun 24, 2026

Option to opt in to showing error codes or show error codes in addition to rule names #26320

Closed

ntBre added 4 commits June 24, 2026 15:34

Allow human-readable names in rule selectors

31c8921

check preview in other cases warn everywhere test all the flags tidy link to this pr on preview feature the per-file-ignore changes especially should be fully reverted

v2 with deferred rule selectors

ff5b9cd

update schema and docs

b001930

generate From<Rule> for RuleSelector

672f9b6

ntBre force-pushed the brent/human-readable-selectors branch from 9d4018f to 672f9b6 Compare June 24, 2026 20:22

ntBre commented Jun 24, 2026

View reviewed changes

ntBre marked this pull request as ready for review June 24, 2026 20:34

ntBre requested a review from MichaReiser June 24, 2026 20:37

MichaReiser approved these changes Jun 25, 2026

View reviewed changes

ntBre added 3 commits June 25, 2026 10:18

store Rule in RuleSelector::Rule

f25e176

backticks around file name

0b5c014

update preview message

df548ec

ntBre merged commit f703f21 into main Jun 25, 2026
76 of 77 checks passed

ntBre deleted the brent/human-readable-selectors branch June 25, 2026 15:34

ntBre mentioned this pull request Jun 25, 2026

Remove RUF076 name from schema #26371

Merged

charliermarsh pushed a commit that referenced this pull request Jun 25, 2026

Remove RUF076 name from schema (#26371)

485ebab

Summary -- I didn't think to rebase #26240 after merging #25887 and there was a conflict in the schema. This should fix the current failure on main. Test Plan -- CI

BrewTestBot mentioned this pull request Jun 25, 2026

ruff 0.15.20 Homebrew/homebrew-core#289873

Merged

Navigation Menu

Uh oh!

Allow human-readable names in rule selectors - #25887

Allow human-readable names in rule selectors#25887
ntBre merged 7 commits into
mainfrom
brent/human-readable-selectors

ntBre commented Jun 11, 2026 •

edited

Loading

Uh oh!

astral-sh-bot Bot commented Jun 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

MichaReiser left a comment

Uh oh!

ntBre commented Jun 15, 2026

Uh oh!

ntBre Jun 24, 2026

Uh oh!

ntBre Jun 24, 2026

Uh oh!

MichaReiser left a comment

Uh oh!

MichaReiser Jun 25, 2026

Uh oh!

ntBre Jun 25, 2026

Uh oh!

MichaReiser Jun 25, 2026

Uh oh!

MichaReiser Jun 25, 2026

Uh oh!

ntBre Jun 25, 2026

Uh oh!

ntBre commented Jun 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	if is_human_readable_names_enabled(preview) {
	return Ok(RuleSelector::from_str(&rule.noqa_code().to_string()).unwrap());
	}

		When [preview mode](preview.md) is enabled, rule selectors also accept the human-readable name of a
		rule (e.g., `unused-import`).

	Cause: Rule name `unused-import` used as selector with preview disabled in `select` from [TMP]/ruff.toml
	Cause: Rule name `unused-import` used as selector with preview disabled in `select` from `[TMP]/ruff.toml`

Uh oh!

Conversation

ntBre commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

astral-sh-bot Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Uh oh!

Uh oh!

MichaReiser left a comment

Choose a reason for hiding this comment

Uh oh!

ntBre commented Jun 15, 2026

Uh oh!

ntBre Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

ntBre Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

MichaReiser left a comment

Choose a reason for hiding this comment

Uh oh!

MichaReiser Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

ntBre Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

MichaReiser Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

MichaReiser Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

ntBre Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

ntBre commented Jun 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ntBre commented Jun 11, 2026 •

edited

Loading

astral-sh-bot Bot commented Jun 11, 2026 •

edited

Loading

`ruff-ecosystem` results