Disable npm caching for playground - #21039
Merged
Merged
Conversation
MichaReiser
force-pushed
the
micha/disable-playground-caching
branch
from
October 23, 2025 07:44
110a073 to
9ce1c2a
Compare
sharkdp
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#20999 broke the ty playground deployment because it
added npm caching without specifying the path to the package.json
I don't think the NPM caching gives us that much (this isn't a workflow that runs for every PR),
especially not if it also introduces us to cache poisoning (while the playground isn't critical,
it's still something that many Astral employees and users access eveyr day).
Test Plan
Test in prod ;)