This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Added support for parsing nested comments - #408
Merged
Conversation
djc
reviewed
Dec 18, 2020
djc
left a comment
djc
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, some style nits.
vallentin
force-pushed
the
nested-comments
branch
2 times, most recently
from
December 18, 2020 13:10
d87d668 to
e49eb60
Compare
djc
reviewed
Dec 18, 2020
vallentin
force-pushed
the
nested-comments
branch
from
December 18, 2020 13:56
e49eb60 to
63896d9
Compare
djc
approved these changes
Dec 18, 2020
Collaborator
Author
|
No problem! Just as a note, I haven't forgotten about #396, I just need to look more into the |
Collaborator
|
No problem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added support for nested comments, i.e.
{# foo {# bar #} baz #}. Now Askama is more on par with Rust.I sometimes comment out chunks of a template when testing stuff. If that chunk already contains comments, then that becomes harder.
Assuming no one has comments like
{# {# #}, then this is a non-breaking change.