Impossible to figure out length of pSeed in pack_C_GenerateRandom_Return

[gijzelaerr]

Everywhere in the API and spec the arrays passed around are bundled with a length variable, with one exception: pSeed in pack_C_GenerateRandom_Return.

keehive/src/generated/pack.c

Line 3538 in 4b247ba

pulSeedLen,

For now this is a hardcoded value (0).

@vanrein proposed to wrap every object into a dercursor. I think this is a bit overkill, since this is the only point that I know of where this is a problem. i propose we change the spec.

[gijzelaerr]

Actually there are 2 more exceptions I see now:
pTemplate in pack_C_GetAttributeValue_Return:

keehive/src/generated/pack.c

Line 3675 in 4b247ba

(sizeof(pTemplate) / sizeof(CK_ATTRIBUTE)),

pLabel in pack_C_InitToken_Call:

keehive/src/generated/pack.c

Line 4950 in 4b247ba

CK_RV pLabel_status = der_put_UTF8String(&C_InitToken_Call.pLabel, pLabel, (sizeof(pLabel) / sizeof(UTF8String)));

I tried to solve it with a sizeof(), but that only works on arrays.

[gijzelaerr]

These are related the last 3 remaining failing tests in test_pack.c.

[gijzelaerr]

pLabel is een fixed length of 32 * UTF8 char. :)

[gijzelaerr]

The tests are not failing anymore, but this is still an issue for pTemplate in pack_C_FindObjectsInit_Return, pTemplate in pack_C_GetAttributeValue_Return and pulSeedLen in pack_C_GenerateRandom_Return.

[gijzelaerr]

I think I must have been tired or something, because the pTemplate variables actually do have a length: 13cbaf9.