fix: avoid "possible EventEmitter memory leak detected" warning by n1ru4l · Pull Request #6789 · ardatan/graphql-tools

n1ru4l · 2024-12-20T13:07:06Z

Description

I noticed the "possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit." warning within our Hive GraphQL API service, which leads back to setting up too many event listeners here.

While the warning is not a real issue, we should avoid triggering it.

Extra from @ardatan ;

Single helper for AbortSignal event listener registration so it can be used by other packages, too.
Replace if(signal.aborted) throw logic with signal?.throwIfAborted
Check if there is only one listener registered to AbortSignal in tests
Shared rejection promise for AbortSignal instead of creating it multiple times

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Existing tests pass, so the provided functionality stays the same.

changeset-bot · 2024-12-20T13:07:10Z

🦋 Changeset detected

Latest commit: 7cec9a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages

Name	Type
@graphql-tools/utils	Minor
@graphql-tools/executor	Patch
@graphql-tools/graphql-tag-pluck	Patch
@graphql-tools/import	Patch
@graphql-tools/links	Patch
@graphql-tools/load	Patch
@graphql-tools/merge	Patch
@graphql-tools/mock	Patch
@graphql-tools/node-require	Patch
@graphql-tools/relay-operation-optimizer	Patch
@graphql-tools/resolvers-composition	Patch
@graphql-tools/schema	Patch
@graphql-tools/apollo-engine-loader	Patch
@graphql-tools/code-file-loader	Patch
@graphql-tools/git-loader	Patch
@graphql-tools/github-loader	Patch
@graphql-tools/graphql-file-loader	Patch
@graphql-tools/json-file-loader	Patch
@graphql-tools/module-loader	Patch
@graphql-tools/url-loader	Patch
@graphql-tools/executor-apollo-link	Patch
@graphql-tools/executor-envelop	Patch
@graphql-tools/executor-legacy-ws	Patch
@graphql-tools/executor-urql-exchange	Patch
@graphql-tools/executor-yoga	Patch
graphql-tools	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

theguild-bot · 2024-12-20T13:31:01Z

🚀 Snapshot Release (`alpha`)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
`@graphql-tools/executor`	`1.3.10-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-apollo-link`	`1.0.9-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-envelop`	`3.0.17-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-legacy-ws`	`1.1.8-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-urql-exchange`	`1.0.10-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-yoga`	`3.0.17-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/graphql-tag-pluck`	`8.3.10-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`graphql-tools`	`9.0.9-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/import`	`7.0.9-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/links`	`9.0.18-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/load`	`8.0.10-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/apollo-engine-loader`	`8.0.10-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/code-file-loader`	`8.1.11-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/git-loader`	`8.0.15-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/github-loader`	`8.0.10-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/graphql-file-loader`	`8.0.9-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/json-file-loader`	`8.0.9-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/module-loader`	`8.0.9-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/url-loader`	`8.0.21-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/merge`	`9.0.15-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/mock`	`9.0.12-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/node-require`	`7.0.10-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/relay-operation-optimizer`	`7.0.9-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/resolvers-composition`	`7.0.9-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/schema`	`10.0.14-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎
`@graphql-tools/utils`	`10.7.0-alpha-20241224080220-7cec9a36c8869567ca685def6970f80d29f8b7f5`	npm ↗︎ unpkg ↗︎

ardatan · 2024-12-23T14:17:06Z

See #6793

We can export a helper to register listeners to the signal so we can benefit this in other packages; Hive Gateway etc.

* Single place for AbortSignal listeners * Fix * .. * Lets go * Small improvement * Changeset for utils

github-actions · 2024-12-24T07:59:26Z

💻 Website Preview

The latest changes are available as preview in: https://7cd867a4.graphql-tools.pages.dev

slagiewka · 2025-01-07T11:24:34Z

FYI node 23.5.0 has this warning disabled for AbortSignal nodejs/node#55816. It's also scheduled to be in 22.13.0 with the backport already done nodejs/node@81c94a32e4

* fix: possible EventEmitter memory leak detected * Single place for AbortSignal listeners -> #6789 (#6793) * Single place for AbortSignal listeners * Fix * .. * Lets go * Small improvement * Changeset for utils * Update packages/executor/src/execution/__tests__/abort-signal.test.ts --------- Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>

n1ru4l requested review from ardatan and saihaj December 20, 2024 13:07

n1ru4l changed the title ~~fix: possible EventEmitter memory leak detected~~ fix: avoid "possible EventEmitter memory leak detected" warning Dec 20, 2024

fix: possible EventEmitter memory leak detected

cfab60c

n1ru4l force-pushed the fix-max-listener-warning branch from 30026af to cfab60c Compare December 20, 2024 13:29

ardatan mentioned this pull request Dec 23, 2024

Single place for AbortSignal listeners -> #6789 #6793

Merged

dotansimha approved these changes Dec 23, 2024

View reviewed changes

ardatan reviewed Dec 23, 2024

View reviewed changes

Comment thread packages/executor/src/execution/execute.ts Outdated

Single place for AbortSignal listeners -> #6789 (#6793)

2da2630

* Single place for AbortSignal listeners * Fix * .. * Lets go * Small improvement * Changeset for utils

ardatan requested a review from dotansimha December 24, 2024 07:57

ardatan reviewed Dec 24, 2024

View reviewed changes

Comment thread packages/executor/src/execution/__tests__/abort-signal.test.ts Outdated

Update packages/executor/src/execution/__tests__/abort-signal.test.ts

7cec9a3

dotansimha approved these changes Dec 24, 2024

View reviewed changes

enisdenjo approved these changes Dec 24, 2024

View reviewed changes

ardatan merged commit 2c70d27 into master Dec 24, 2024

ardatan deleted the fix-max-listener-warning branch December 24, 2024 11:58

theguild-bot mentioned this pull request Dec 24, 2024

Upcoming Release Changes #6798

Merged

ardatan mentioned this pull request Dec 24, 2024

Bump Tools dependencies, and use new helpers to improve AbortSignal handling graphql-hive/gateway#373

Merged

ardatan mentioned this pull request Feb 4, 2025

Simplify and stabilise AbortSignal.any ponyfill graphql-hive/gateway#593

Closed

1 task

Navigation Menu

Uh oh!

fix: avoid "possible EventEmitter memory leak detected" warning - #6789

fix: avoid "possible EventEmitter memory leak detected" warning#6789
ardatan merged 3 commits into
masterfrom
fix-max-listener-warning

n1ru4l commented Dec 20, 2024 •

edited by ardatan

Loading

Uh oh!

changeset-bot Bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

theguild-bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

Uh oh!

ardatan commented Dec 23, 2024

Uh oh!

github-actions Bot commented Dec 24, 2024 •

edited

Loading

Uh oh!

Uh oh!

slagiewka commented Jan 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

n1ru4l commented Dec 20, 2024 • edited by ardatan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Uh oh!

changeset-bot Bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

theguild-bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (alpha)

Uh oh!

Uh oh!

ardatan commented Dec 23, 2024

Uh oh!

github-actions Bot commented Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💻 Website Preview

Uh oh!

Uh oh!

slagiewka commented Jan 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

n1ru4l commented Dec 20, 2024 •

edited by ardatan

Loading

changeset-bot Bot commented Dec 20, 2024 •

edited

Loading

theguild-bot commented Dec 20, 2024 •

edited

Loading

🚀 Snapshot Release (`alpha`)

github-actions Bot commented Dec 24, 2024 •

edited

Loading