Skip to content

publish: check if storage exists#1587

Merged
neolynx merged 1 commit into
masterfrom
fix/check-storage-exists
Jun 18, 2026
Merged

publish: check if storage exists#1587
neolynx merged 1 commit into
masterfrom
fix/check-storage-exists

Conversation

@neolynx

@neolynx neolynx commented Jun 18, 2026

Copy link
Copy Markdown
Member

Fixes #1477

Description of the Change

Check if storage actually exists in GetPublishedStorage, or return an error (instead of crashing).

Checklist

  • unit-test added/updated

@neolynx neolynx self-assigned this Jun 18, 2026
@neolynx neolynx force-pushed the fix/check-storage-exists branch from f5a94f5 to 950dc57 Compare June 18, 2026 13:51
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.00000% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.36%. Comparing base (29e643c) to head (dd85493).

Files with missing lines Patch % Lines
context/context.go 50.00% 9 Missing ⚠️
deb/publish.go 42.85% 4 Missing and 4 partials ⚠️
cmd/serve.go 0.00% 4 Missing ⚠️
api/repos.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1587      +/-   ##
==========================================
- Coverage   77.43%   77.36%   -0.07%     
==========================================
  Files         165      165              
  Lines       15707    15726      +19     
==========================================
+ Hits        12162    12167       +5     
- Misses       2344     2353       +9     
- Partials     1201     1206       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@neolynx neolynx requested a review from a team June 18, 2026 15:57
@neolynx neolynx added this to the 1.6.3 milestone Jun 18, 2026
@neolynx neolynx added the needs review Ready for review & merge label Jun 18, 2026
@neolynx neolynx force-pushed the fix/check-storage-exists branch 2 times, most recently from 72b5e24 to b92328c Compare June 18, 2026 17:15
@neolynx neolynx force-pushed the fix/check-storage-exists branch 2 times, most recently from 230fc83 to 1fbb755 Compare June 18, 2026 19:32
@neolynx neolynx force-pushed the fix/check-storage-exists branch from 1fbb755 to dd85493 Compare June 18, 2026 19:35
@neolynx neolynx merged commit 4a19238 into master Jun 18, 2026
48 of 49 checks passed
@neolynx neolynx deleted the fix/check-storage-exists branch June 18, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review Ready for review & merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aptly-api.service crashes when publishing to non-existing filesystem-publish-endpoint

2 participants