Add mutex on LinkFromPool to fix #1449#1481
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1481 +/- ##
==========================================
- Coverage 74.86% 74.55% -0.31%
==========================================
Files 159 159
Lines 18438 18454 +16
==========================================
- Hits 13803 13759 -44
- Misses 3489 3553 +64
+ Partials 1146 1142 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
you guys are heroes ! 🥇 |
iofq
approved these changes
Aug 28, 2025
iofq
left a comment
iofq
left a comment
Contributor
There was a problem hiding this comment.
LGTM. One nitpick about the length of the unit test, but fine to merge as-is.
This fixes the race condition that happens when you call publish concurrently. It adds a valuable test that reproduces the error almost deterministically, it's hard to say always but I have run this in loop 100 times and it reproduces the error consistently without the patch and after the patch it works consistently.
Contributor
|
@neolynx can you merge? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the race condition that happens when you call publish concurrently. It adds a valuable test that reproduces the error almost deterministically, it's hard to say always but I have run this in loop 100 times and it reproduces the error consistently without the patch and after the patch it works consistently.
Fixes #1449
Checklist
AUTHORS