Fix value comparison, argument merging, and link feature addition/extraction in composition - #3134
Merged
Conversation
🦋 Changeset detectedLatest commit: 2e54f98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for apollo-federation-docs canceled.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
sachindshinde
force-pushed
the
sachin/cost-tweaks
branch
from
August 31, 2024 05:45
82376e6 to
fc8224d
Compare
sachindshinde
force-pushed
the
sachin/cost-tweaks
branch
2 times, most recently
from
September 3, 2024 20:05
9fac996 to
babcdc4
Compare
sachindshinde
changed the title
sachindshinde
changed the title
tninesling
approved these changes
Sep 9, 2024
clenfest
approved these changes
Sep 12, 2024
sachindshinde
force-pushed
the
sachin/cost-tweaks
branch
from
September 13, 2024 23:24
99e028e to
2e54f98
Compare
sachindshinde
added a commit
that referenced
this pull request
Sep 17, 2024
sachindshinde
added a commit
that referenced
this pull request
Sep 17, 2024
sachindshinde
added a commit
that referenced
this pull request
Sep 17, 2024
sachindshinde
pushed a commit
that referenced
this pull request
Sep 18, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/composition@2.9.1 ### Patch Changes - Fix bugs in composition when merging nulls in directive applications and when handling renames. ([#3134](#3134)) - Updated dependencies \[[`b8e4ab5352a4dfd262af49493fdd42e86e5e3d99`](b8e4ab5), [`e6c05b6c96023aa3dec79889431f8217fcb3806d`](e6c05b6)]: - @apollo/federation-internals@2.9.1 - @apollo/query-graphs@2.9.1 ## @apollo/gateway@2.9.1 ### Patch Changes - Fix bugs in composition when merging nulls in directive applications and when handling renames. ([#3134](#3134)) - Updated dependencies \[[`b8e4ab5352a4dfd262af49493fdd42e86e5e3d99`](b8e4ab5), [`e6c05b6c96023aa3dec79889431f8217fcb3806d`](e6c05b6)]: - @apollo/federation-internals@2.9.1 - @apollo/composition@2.9.1 - @apollo/query-planner@2.9.1 ## @apollo/federation-internals@2.9.1 ### Patch Changes - Fix edge cases for subgraph extraction logic when using spec renaming or specs URLs that look similar to `specs.apollo.dev`. ([#3136](#3136)) - Fix bugs in composition when merging nulls in directive applications and when handling renames. ([#3134](#3134)) ## @apollo/query-graphs@2.9.1 ### Patch Changes - Updated dependencies \[[`b8e4ab5352a4dfd262af49493fdd42e86e5e3d99`](b8e4ab5), [`e6c05b6c96023aa3dec79889431f8217fcb3806d`](e6c05b6)]: - @apollo/federation-internals@2.9.1 ## @apollo/query-planner@2.9.1 ### Patch Changes - Updated dependencies \[[`b8e4ab5352a4dfd262af49493fdd42e86e5e3d99`](b8e4ab5), [`e6c05b6c96023aa3dec79889431f8217fcb3806d`](e6c05b6)]: - @apollo/federation-internals@2.9.1 - @apollo/query-graphs@2.9.1 ## @apollo/subgraph@2.9.1 ### Patch Changes - Updated dependencies \[[`b8e4ab5352a4dfd262af49493fdd42e86e5e3d99`](b8e4ab5), [`e6c05b6c96023aa3dec79889431f8217fcb3806d`](e6c05b6)]: - @apollo/federation-internals@2.9.1 ## apollo-federation-integration-testsuite@2.9.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing recent code changes that released in
2.9.0, I noticed a few bugs in the code, so I've pushed some fixes for them in this PR (along with some fixes for more ancient bugs).I'll comment on the code with more details, but to summarize the fixes:
nulls/undefineds better.SUMstrategy, as using it currently wouldn't yield expected results since directive applications are deduped before being merged.@linkapplications to the supergraph schema for supergraph specs needed by subgraph directives has been updated to handle specs that have multiple directives that need composing (the behavior before was adding spurious directive definitions to the supergraph schema).@core/@linkwas off.