Skip to content

Add support for tag v0.2 - #1652

Merged
sachindshinde merged 3 commits into
apollographql:mainfrom
sachindshinde:fed2/tag-v0.2-updates
Mar 29, 2022
Merged

Add support for tag v0.2#1652
sachindshinde merged 3 commits into
apollographql:mainfrom
sachindshinde:fed2/tag-v0.2-updates

Conversation

@sachindshinde

@sachindshinde sachindshinde commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

This PR introduces tag v0.2, which adds support for @tag in more locations (arguments, scalars, enums, enum values, input objects, input object fields).

@netlify

netlify Bot commented Mar 28, 2022

Copy link
Copy Markdown

馃懛 Deploy request for apollo-federation-docs pending review.

Visit the deploys page to approve it

Name Link
馃敤 Latest commit dff6b55

@codesandbox-ci

codesandbox-ci Bot commented Mar 28, 2022

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@sachindshinde
sachindshinde requested a review from pcmanus March 28, 2022 11:58
Comment thread subgraph-js/src/directives.ts Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to remove the special case for isInputObjectType just before this line? (I'll note that this method is only used internally in the case of object types, so doesn't matter so far for our internal usage, but since it's exported ...).

@sachindshinde
sachindshinde force-pushed the fed2/tag-v0.2-updates branch 2 times, most recently from f9f2349 to ec0ee3b Compare March 29, 2022 08:06
@sachindshinde
sachindshinde force-pushed the fed2/tag-v0.2-updates branch from ec0ee3b to dff6b55 Compare March 29, 2022 08:46
@sachindshinde
sachindshinde merged commit 3a7d833 into apollographql:main Mar 29, 2022
@sachindshinde
sachindshinde deleted the fed2/tag-v0.2-updates branch March 29, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants