chore(deps): Update graphql and related dependencies - #1200
Merged
Conversation
trevor-scheer
requested review from
abernix,
martijnwalraven and
pcmanus
and removed request for
abernix
November 12, 2021 01:30
Contributor
Author
|
Is there any reason we'd want to continue supporting I'd like to get gateway supporting v16 asap, this seems like a good first step. Unfortunately there's a minor version bump in |
Updates on the TypeScript query planner changed the PlanningError structure, that will now always have an `extensions` field. No extensions are now expressed by having the extensions field value being null, or an empty Object. This PR allows us to express these requirements by: - Adding a new deserialize directive `none_only_if_value_is_null_or_empty_object`. - Applying the directive to the `PlanningError::extensions` field. - Adding comments and tests that make the new requirement more explicit.
Contributor
|
I'm not qualified to judge the Rust stuff, but if it compiles, it's probably fine, right? Otherwise LGTM. |
Contributor
Author
Contributor
Author
|
Leaving this for @pcmanus or @martijnwalraven to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.