PHOENIX-7927 Fix EXPLAIN plumbing related NPE in DelegateQueryPlan.setOptimizerDecision - #2532
Merged
Merged
Conversation
…tOptimizerDecision
There was a problem hiding this comment.
Pull request overview
Fixes a regression where DelegateQueryPlan.setOptimizerDecision() could throw an NPE during EXPLAIN plumbing when a DelegateQueryPlan is intentionally constructed with a null delegate (e.g., via ClientProcessingPlan in queries involving TOTAL_SEGMENTS).
Changes:
- Add local fallback storage for
OptimizerDecisioninDelegateQueryPlanwhen no delegate is present. - Guard optimizer-decision getter/setter to forward to the delegate when non-null, otherwise use the fallback field.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apurtell
added a commit
to apurtell/phoenix
that referenced
this pull request
Jun 17, 2026
…tOptimizerDecision (apache#2532) Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jul 24, 2026
…tOptimizerDecision (#2532) Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
apurtell
added a commit
to apurtell/phoenix
that referenced
this pull request
Aug 4, 2026
…tOptimizerDecision (apache#2532) Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NPE in
DelegateQueryPlan.setOptimizerDecisionbecause the delegate is null, viaTotalSegmentsFunctionIT.getApplicablePlansForSingleFlatQuerycan callrecordDecisionon aDelegateQueryPlanwith a null delegate.ClientProcessingPlanoverridesgetContext()/getTableRef()/getProjector()to use local fields, so a null delegate is fine except for the two optimizer-decision accessors thatDelegateQueryPlanis forwarding unconditionally. This is a regression from PHOENIX-7891 that breaks any query involvingTOTAL_SEGMENTS.Co-authored-by: Claude Opus 4.8[1m] noreply@anthropic.com