PHOENIX-7921 Remove unread bookkeeping state from StatementContext

[apurtell]

Remove unused bookkeeping from StatementContext. Drops unionTags, addLiftedHavingNode(), isLiftedHavingNode() and the backing liftedHavingNodes set (the HAVING-lift breadcrumb is still emitted as a REWRITE HAVING PREDICATE AS WHERE line via appliedRewrites), and addIndexExpressionSubstitution() / getIndexExpressionSubstitutions() and the backing indexExpressionSubstitutions list. Removes the corresponding fields, their entries in the copy constructor, the no-arg-init constructor, and adoptRewriteState, plus the now-dead breadcrumbContext.addIndexExpressionSubstitution() call in IndexExpressionParseNodeRewriter and the addLiftedHavingNode loop in HavingCompiler. No behavior change. EXPLAIN text and JSON output are unchanged.

[Copilot]

Pull request overview

Removes unused diagnostic/bookkeeping state from StatementContext and deletes the now-dead call sites that populated it, while preserving the existing rewrite breadcrumbs (appliedRewrites) used for EXPLAIN output.

Changes:

• Remove indexExpressionSubstitutions tracking and related APIs from StatementContext, plus the dead recorder call in IndexExpressionParseNodeRewriter.
• Remove liftedHavingNodes / addLiftedHavingNode() / isLiftedHavingNode() from StatementContext, plus the dead recording loop in HavingCompiler.
• Remove the unused unionTags() helper from StatementContext.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
phoenix-core-client/src/main/java/org/apache/phoenix/parse/IndexExpressionParseNodeRewriter.java	Drops the now-unused breadcrumbContext.addIndexExpressionSubstitution(...) call, leaving breadcrumb emission via addAppliedRewrite(...).
phoenix-core-client/src/main/java/org/apache/phoenix/compile/StatementContext.java	Deletes unused fields and methods (indexExpressionSubstitutions, liftedHavingNodes, unionTags) and removes their propagation via constructors/adoption.
phoenix-core-client/src/main/java/org/apache/phoenix/compile/HavingCompiler.java	Removes the loop that recorded lifted HAVING parse nodes, retaining the rewrite breadcrumb.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[apurtell]

Test Results

Unit tests (*Test) — full reactor

Module	Tests	Failures	Errors	Skipped	Result
phoenix-core-client	0	0	0	0	no unit tests in module
phoenix-core-server	0	0	0	0	no unit tests in module
phoenix-core	2580	0	0	9	PASS

All unit tests covering the modified code paths passed:

Test class	Tests	Result
query.explain.ExplainPlanTest	105	PASS
query.explain.ExplainJsonOutputTest	2	PASS
parse.ExplainOptionsParserTest	16	PASS
compile.HavingCompilerTest	11	PASS
compile.QueryOptimizerTest	52	PASS
compile.WhereOptimizerTest	138	PASS
compile.QueryCompilerTest	215	PASS

Impacted integration tests (*IT)

Selected because they directly assert EXPLAIN output through the modified compile paths (functional/partial-index expression rewrite, HAVING-as-WHERE lift, derived-table flatten).

IT class	Tests	Failures	Errors	Skipped	Time	Result
end2end.ExplainPlanWithStatsDisabledIT	17	0	0	0	73.9 s	PASS
end2end.DerivedTableIT	18	0	0	0	86.7 s	PASS
end2end.ExplainPlanWithStatsEnabledIT	30	0	0	0	101.6 s	PASS
end2end.index.PartialIndexIT	64	0	0	0	453.9 s	PASS
Total	129	0	0	0	—	BUILD SUCCESS