This repository was archived by the owner on Nov 17, 2023. It is now read-only.
A solution to prevent zombie containers locally and in CI - #12381
Merged
Conversation
larroy
force-pushed
the
zombies_singled
branch
from
August 28, 2018 15:44
7bc6596 to
ab8d46b
Compare
Fix pylint, mypy, and pycharm code inspection warnings
larroy
force-pushed
the
zombies_singled
branch
from
August 28, 2018 15:54
ab8d46b to
032e46c
Compare
5 tasks
KellenSunderland
approved these changes
Aug 28, 2018
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Sep 19, 2018
Fix pylint, mypy, and pycharm code inspection warnings
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds mechanisms on the build scripts to cleanup docker containers when there is a cancellation, either from the user by sending SIGINT / SIGTERM or when the process inside the container ends with an error.
It also propagates the environment variables from Jenkins which are used by the process tree killer to identify runaway processes so processes inside the container are killed when the Jenkins job is stopped.
With this patch we catch SIGINT and SIGTERM and install a handler on atexit which cleans (stops) docker containers which were created during execution of the build.
We also switch to python docker API for better management of running containers.
@aaronmarkham @marcoabreu @lebeg @KellenSunderland
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes