Skip to content

Enable Maven 4 build - #1323

Open
Bukama wants to merge 3 commits into
apache:masterfrom
Bukama:maven4enable
Open

Enable Maven 4 build#1323
Bukama wants to merge 3 commits into
apache:masterfrom
Bukama:maven4enable

Conversation

@Bukama

@Bukama Bukama commented May 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Bukama

Bukama commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

Note: This PR is for checking build status for Maven 4.0.0 according to checklist https://cwiki.apache.org/confluence/display/MAVEN/Maven+4.0.0+GA+checklist

@Bukama

Bukama commented May 18, 2026

Copy link
Copy Markdown
Contributor Author
D:\Github\Maven\maven-jmod-plugin>mvn --version
Apache Maven 4.0.0-rc-5 (fb3ecaef88106acb40467a450248dfdbd75f3b35)
Maven home: C:\apache-maven-4.0.0-rc-5
Java version: 25.0.2, vendor: Azul Systems, Inc., runtime: C:\Program Files\Zulu\zulu-25
Default locale: de_DE, platform encoding: UTF-8
OS name: "windows 11", version: "10.0", arch: "amd64", family: "winnt"

[ERROR] The following builds failed:
[ERROR] *  MJAVADOC-639_requires_ignored\pom.xml

On JDK 17 and 21 (both GitHub)

Error:  The following builds failed:
Error:  *  MJAVADOC-338_downloadSources/pom.xml
Error:  *  MJAVADOC-639_requires_ignored/pom.xml
[INFO] --------------------------------------------

338_downloadSources

Here it seems to have troubles with MRM as it is not taken into account. On my local machine it works

[INFO] Building: MJAVADOC-338_downloadSources/pom.xml
[INFO] run post-build script verify.groovy
[INFO]   Assertion failed: 

assert 1 == buildLog.readLines().count{it ==~ /\[INFO\] Downloading from mrm-maven-plugin\: .+\/mjavadoc338-direct-1\.0-sources\.jar/}
         |  |        |           |
         |  |        |           0
         |  |        ['Picked up _JAVA_OPTIONS: -Dabc=def', '[INFO] Scanning for projects...', '[INFO] ', '[INFO] ----------< org.apache.maven.plugins.javadoc.it:mjavadoc338 >-----------', '[INFO] Building mjavadoc338 1.0-SNAPSHOT', '[INFO]   from pom.xml', '[INFO] --------------------------------[ jar ]---------------------------------', '[INFO] ', '[INFO] --- javadoc:3.12.1-SNAPSHOT:javadoc (default-cli) @ mjavadoc338 ---', '[INFO] ------------------------------------------------------------------------', '[INFO] BUILD SUCCESS', '[INFO] ------------------------------------------------------------------------', '[INFO] Total time:  2.439 s', '[INFO] Finished at: 2026-05-14T18:10:35Z', '[INFO] ------------------------------------------------------------------------', 'Picked up _JAVA_OPTIONS: -Dabc=def', '[INFO] Scanning for projects...', '[INFO] ', '[INFO] ----------< org.apache.maven.plugins.javadoc.it:mjavadoc338 >-----------', '[INFO] Building mjavadoc338 1.0-SNAPSHOT', '[INFO]   from pom.xml', '[INFO] --------------------------------[ jar ]---------------------------------', '[INFO] ', '[INFO] --- javadoc:3.12.1-SNAPSHOT:javadoc (default-cli) @ mjavadoc338 ---', '[INFO] ------------------------------------------------------------------------', '[INFO] BUILD SUCCESS', '[INFO] ------------------------------------------------------------------------', '[INFO] Total time:  1.152 s', '[INFO] Finished at: 2026-05-14T18:10:40Z', '[INFO] ------------------------------------------------------------------------', 'Running post-build script: /Users/runner/work/maven-javadoc-plugin/maven-javadoc-plugin/target/it/MJAVADOC-338_downloadSources/verify.groovy']
         |  /Users/runner/work/maven-javadoc-plugin/maven-javadoc-plugin/target/it/MJAVADOC-338_downloadSources/build.log
         false

639_requires_ignored

Fails to invalid plugin pulled in.

[INFO] Reactor Summary for MJAVADOC-639 1.0.0-SNAPSHOT:
[INFO] 
[INFO] MJAVADOC-639 ....................................... SUCCESS [  1.547 s]
[INFO] modulea ............................................ FAILURE [  0.952 s]
[INFO] moduleb ............................................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  3.532 s
[INFO] Finished at: 2026-05-18T20:34:31+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-source-plugin:4.0.0-beta-1:jar (default-cli) on project modulea: Execution default-cli of goal org.apache.maven.plugins:maven-source-plugin:4.0.0-beta-1:jar failed: An API incompatibility was encountered while executing org.apache.maven.plugins:maven-source-plugin:4.0.0-beta-1:jar: java.lang.NoSuchMethodError: 'java.util.List org.apache.maven.api.services.ProjectManager.getCompileSourceRoots(org.apache.maven.api.Project, org.apache.maven.api.ProjectScope)'

@Bukama

Bukama commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

Testing with current 4.0.0-Snapshot (f92777366ff21bd9b80656d639b2221b46c56e24), but same result (639_requires_ignored fails, but 338_downloadSources works locally)

@hboutemy

hboutemy commented Jun 13, 2026

Copy link
Copy Markdown
Member

still 1 issue with Maven 4.0.0-rc5:

[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO]   Passed: 81, Failed: 1, Errors: 0, Skipped: 10
[INFO] -------------------------------------------------
Error:  The following builds failed:
Error:  *  MJAVADOC-338_downloadSources/pom.xml
[INFO] -------------------------------------------------

=

Running post-build script: /home/runner/work/maven-javadoc-plugin/maven-javadoc-plugin/target/it/MJAVADOC-338_downloadSources/verify.groovy
Assertion failed: 

assert 1 == buildLog.readLines().count{it ==~ /\[INFO\] Downloading from mrm-maven-plugin\: .+\/mjavadoc338-direct-1\.0-sources\.jar/}
         |  |        |           |
         |  |        |           0
         |  |        ['Picked up _JAVA_OPTIONS: -Dabc=def', '[INFO] Scanning for projects...', '[INFO] ', '[INFO] ----------< org.apache.maven.plugins.javadoc.it:mjavadoc338 >-----------', '[INFO] Building mjavadoc338 1.0-SNAPSHOT', '[INFO]   from pom.xml', '[INFO] --------------------------------[ jar ]---------------------------------', '[INFO] ', '[INFO] --- javadoc:3.12.1-SNAPSHOT:javadoc (default-cli) @ mjavadoc338 ---', '[INFO] ------------------------------------------------------------------------', '[INFO] BUILD SUCCESS', '[INFO] ------------------------------------------------------------------------', '[INFO] Total time:  2.352 s', '[INFO] Finished at: 2026-06-13T07:40:11Z', '[INFO] ------------------------------------------------------------------------', 'Picked up _JAVA_OPTIONS: -Dabc=def', '[INFO] Scanning for projects...', '[INFO] ', '[INFO] ----------< org.apache.maven.plugins.javadoc.it:mjavadoc338 >-----------', '[INFO] Building mjavadoc338 1.0-SNAPSHOT', '[INFO]   from pom.xml', '[INFO] --------------------------------[ jar ]---------------------------------', '[INFO] ', '[INFO] --- javadoc:3.12.1-SNAPSHOT:javadoc (default-cli) @ mjavadoc338 ---', '[INFO] ------------------------------------------------------------------------', '[INFO] BUILD SUCCESS', '[INFO] ------------------------------------------------------------------------', '[INFO] Total time:  1.394 s', '[INFO] Finished at: 2026-06-13T07:40:14Z', '[INFO] ------------------------------------------------------------------------', 'Running post-build script: /home/runner/work/maven-javadoc-plugin/maven-javadoc-plugin/target/it/MJAVADOC-338_downloadSources/verify.groovy']
         |  /home/runner/work/maven-javadoc-plugin/maven-javadoc-plugin/target/it/MJAVADOC-338_downloadSources/build.log
         false

no idea why it happens on the GHA nodes, but not on my laptop

@hboutemy

Copy link
Copy Markdown
Member

on my laptop:

[INFO] --- invoker:3.10.1:integration-test (integration-test) @ maven-javadoc-plugin ---
[INFO] Building: MJAVADOC-338_downloadSources/pom.xml
[INFO]           MJAVADOC-338_downloadSources/pom.xml ............. SUCCESS (4.048 s)
[INFO] Building: MJAVADOC-620_no-dot-in-version/pom.xml
[INFO]           MJAVADOC-620_no-dot-in-version/pom.xml ........... SUCCESS (5.743 s)
...

but on CI

[INFO] --- invoker:3.10.1:integration-test (integration-test) @ maven-javadoc-plugin ---
[INFO] Building: MJAVADOC-571_aggr-empty-sourcepaths/pom.xml
[INFO]           MJAVADOC-571_aggr-empty-sourcepaths/pom.xml ...... SUCCESS (8.006 s)
[INFO] Building: MJAVADOC-634-module-testreports/pom.xml
[INFO]           MJAVADOC-634-module-testreports/pom.xml .......... SUCCESS (5.968 s)
... many ITs ...
[INFO] Building: MJAVADOC-338_downloadSources/pom.xml
[INFO]   Assertion failed: 

I guess it's the order of execution that counts: multiple ITs download the lib, then the assertion fails when the lib was downloaded by a previous IT

flacky IT...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants