KAFKA-19082:[4/4] Complete Txn Client Side Changes (KIP-939)#19714
Merged
jolshan merged 7 commits intoapache:trunkfrom May 29, 2025
Merged
KAFKA-19082:[4/4] Complete Txn Client Side Changes (KIP-939)#19714jolshan merged 7 commits intoapache:trunkfrom
jolshan merged 7 commits intoapache:trunkfrom
Conversation
rreddy-22
force-pushed
the
KAFKA-19082-CompleteTxn-Client-changes-Pt4
branch
from
db9191b to
18c6d6f
Compare
jolshan
reviewed
May 28, 2025
| * If they match, the transaction is committed; otherwise, it is aborted. | ||
| * | ||
| * @param preparedTxnState The prepared transaction state to compare against the current state | ||
| * @throws IllegalStateException if the producer is not in prepared transaction state |
Member
There was a problem hiding this comment.
what is the difference between IlegalState and InvalidTxnState?
Contributor
Author
There was a problem hiding this comment.
Ah my bad, I didn't change the Javadoc, illegalState. From my understanding, IllegalStateException is used when the producer is in an incorrect state and cannot use the API?
InvalidTxnStateException is used for when the transaction is in the wrong state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
public void completeTransaction(PreparedTxnState preparedTxnState)
The method compares the currently prepared transaction state and the
state passed in the argument.
If the producer is not in a prepared state (i.e., neither
prepareTransaction was called nor initTransaction(true) was called), we
return an INVALID_TXN_STATE error.
Reviewers: Justine Olshan jolshan@confluent.io, Artem Livshits
alivshits@confluent.io