Dell: Reject negative ECS stream seeks - #17962
Open
charliec05 wants to merge 1 commit into
Open
Conversation
Validate seek positions before updating pending stream state so invalid offsets fail without corrupting the next read. Generated-by: Codex
Contributor
Author
|
Hi @singhpk234, would you be willing to review this focused Dell ECS stream fix? It rejects negative seeks without corrupting the pending stream position, includes regression coverage, and all 42 CI checks pass. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EcsSeekableInputStream.seekMotivation
The other cloud-backed seekable streams reject negative positions. The ECS implementation instead stored
-1in its pending-position field, where-1is also the sentinel for "no pending seek." This discarded the prior seek state and could leave the next read without an initialized underlying stream.Testing
./gradlew :iceberg-dell:spotlessApply :iceberg-dell:testAI Disclosure