Parquet: Fix Variant conversion in default Avro writer - #17944
Open
2dmurali wants to merge 1 commit into
Open
Conversation
Author
|
Hi @nssalian could you take a look at this PR? I noticed you've been actively driving the Variant type feature, so I'd really appreciate your thoughts and review when you have a chance. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The default Parquet Avro writer registers
VariantConversion, but conversion lookup does not recognize implementations of theVariantinterface.Values created using
Variant.of(...)have the runtime typeVariantData. Avro's exact-class conversion lookup therefore misses the conversion registered forVariant.classand attempts to handle the value as anIndexedRecord, causing aClassCastException.Changes
VariantConversionfor logical Variant values whose runtime classes implementVariant.GenericData.Recordthrough the default Parquet writer and verifies the Variant value after reading it back.Testing
./gradlew :iceberg-parquet:test./gradlew spotlessCheck./gradlew build -x test -x integrationTestCloses #17943