Fix precision loss in large integral string conversions#3405
Open
fallintoplace wants to merge 2 commits into
Open
Fix precision loss in large integral string conversions#3405fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes precision loss when converting large integral strings in two runtime paths:
StringLiteral.to(IntegerType/LongType)partition_to_py(...)for integral and time-based partition values backed by integersRoot cause
Both paths were converting through
floatbefore converting toint, which loses precision for values outside the IEEE-754 exact integer range.That caused valid 64-bit integers like
LongType.maxand9007199254740993to be corrupted.What changed
int(float(...))with exact integer parsing inpartition_to_pyStringLiteral.to(IntegerType/LongType), exact integral strings now use exact integer parsing while fractional numeric strings retain the existing truncation behaviorLongType.maxand9007199254740993Validation
uv run pytest tests/expressions/test_literals.py tests/test_conversions.pyCloses #3404.