chore: better error handling of nlohmann json lib apis#95
Merged
Conversation
1. switch off exceptions for nlohmann::json::parse 2. add a no except wrapper around json.dump, since we don't handle exceptions in Error messages. This closes issue apache#87 References: - https://json.nlohmann.me/features/parsing/parse_exceptions/ - https://json.nlohmann.me/api/basic_json/dump/ Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
wgtmac
reviewed
May 11, 2025
Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
lidavidm
approved these changes
May 12, 2025
Fokko
approved these changes
May 12, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
switch off exceptions for nlohmann::json::parse
add a no except wrapper around json.dump, since we don't handle exceptions in Error messages.
This closes issue #87
References: