feat(hive): add iceberg_hive library backed by Arrow bundled Thrift#753
Open
MisterRaindrop wants to merge 1 commit into
Open
feat(hive): add iceberg_hive library backed by Arrow bundled Thrift#753MisterRaindrop wants to merge 1 commit into
MisterRaindrop wants to merge 1 commit into
Conversation
MisterRaindrop
force-pushed
the
feat/hive-thrift-codegen-clean
branch
3 times, most recently
from
8068c90 to
358a079
Compare
Build checked-in HMS bindings into libiceberg_hive with a stub HiveCatalog and HMS connection properties. Reuse Arrow bundled Thrift runtime and suppress generated-source deprecated-declaration warnings.
MisterRaindrop
force-pushed
the
feat/hive-thrift-codegen-clean
branch
from
358a079 to
970ecfe
Compare
wgtmac
reviewed
Jun 18, 2026
| resolve_sql_catalog_dependencies() | ||
| endif() | ||
|
|
||
| # Arrow's bundled build creates the Thrift C++ runtime as a `thrift` target |
Member
There was a problem hiding this comment.
I'd recommend follow resolve_aws_sdk_dependency and ICEBERG_AWSSDK_BUNDLED to either bundle or use system thrift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iceberg_hivelibrary wiring for the checked-in HMS/fb303 bindings.HiveCatalogand HMS connection properties.