feat: add Iceberg v3 type definitions#752
Open
zhjwpku wants to merge 3 commits into
Open
Conversation
zhjwpku
force-pushed
the
add-iceberg-v3-types
branch
from
1c1f95c to
00c7860
Compare
Introduce the Iceberg v3 types (variant, geometry, geography), including their schema/JSON serialization and type-system integration (visitors, schema projection, etc.). Reading and writing data of these types is not implemented yet: conversion to/from Arrow, Avro, and Parquet returns an error, as do identity transform binding and scalar validation for them.
zhjwpku
force-pushed
the
add-iceberg-v3-types
branch
from
00c7860 to
2b09f55
Compare
WZhuo
reviewed
Jun 17, 2026
evindj
approved these changes
Jun 17, 2026
wgtmac
reviewed
Jun 18, 2026
| explicit GeometryType(std::string crs); | ||
| ~GeometryType() override = default; | ||
|
|
||
| [[nodiscard]] std::string_view crs() const; |
Member
There was a problem hiding this comment.
Suggested change
| [[nodiscard]] std::string_view crs() const; | |
| std::string_view crs() const; |
Collaborator
Author
There was a problem hiding this comment.
Done. I removed all remaining [[nodiscard]] annotations in type.h
| bool Equals(const Type& other) const override; | ||
|
|
||
| private: | ||
| std::optional<std::string> crs_; |
Member
There was a problem hiding this comment.
Empty thing is enough to represent a missing crs.
Collaborator
Author
There was a problem hiding this comment.
Agreed, changed to string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the Iceberg v3 types (variant, geometry, geography), including their schema/JSON serialization and type-system integration (visitors, schema projection, etc.).
Reading and writing data of these types is not implemented yet: conversion to/from Arrow, Avro, and Parquet returns an error, as do identity transform binding and scalar validation for them.