feat: add expression visitors#311
Merged
Merged
Conversation
wgtmac
force-pushed
the
expr_visitor
branch
2 times, most recently
from
November 11, 2025 15:56
f88a20f to
b541297
Compare
- Add template ExpressionVisitor and BoundVisitor - Implement Binder, IsBoundVisitor and RewriteNot
HuaHuaY
reviewed
Nov 12, 2025
HuaHuaY
reviewed
Nov 12, 2025
HuaHuaY
reviewed
Nov 12, 2025
HuaHuaY
reviewed
Nov 12, 2025
Co-authored-by: Zehua Zou <zehuazou2000@gmail.com>
Co-authored-by: Zehua Zou <zehuazou2000@gmail.com>
Co-authored-by: Zehua Zou <zehuazou2000@gmail.com>
Co-authored-by: Zehua Zou <zehuazou2000@gmail.com>
HuaHuaY
suggested changes
Nov 14, 2025
Co-authored-by: Zehua Zou <zehuazou2000@gmail.com>
Co-authored-by: Zehua Zou <zehuazou2000@gmail.com>
Co-authored-by: Zehua Zou <zehuazou2000@gmail.com>
Co-authored-by: Zehua Zou <zehuazou2000@gmail.com>
zhjwpku
approved these changes
Nov 16, 2025
zhjwpku
left a comment
zhjwpku
left a comment
Collaborator
There was a problem hiding this comment.
+1, thanks for working on this.
gty404
reviewed
Nov 17, 2025
| } | ||
|
|
||
| Result<bool> IsBoundVisitor::Or(bool left_result, bool right_result) { | ||
| return left_result && right_result; |
Contributor
There was a problem hiding this comment.
Suggested change
| return left_result && right_result; | |
| return left_result || right_result; |
Member
Author
There was a problem hiding this comment.
I don't think this is correct because this is not a logical operation. We can only return true if both sides are bound expressions. See java impl for reference: https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/expressions/Binder.java#L208-L245
| Result<std::shared_ptr<Expression>> Binder::Predicate( | ||
| const std::shared_ptr<BoundPredicate>& pred) { | ||
| ICEBERG_DCHECK(pred != nullptr, "Predicate cannot be null"); | ||
| return InvalidExpression("Found already bound predicate: {}", pred->ToString()); |
Contributor
There was a problem hiding this comment.
Does additional commentary need to be added here? If an already bound expression is encountered, choose to report an error rather than directly using it.
Member
Author
There was a problem hiding this comment.
Did you mean that we need to add a comment on why an error is returned here?
Fokko
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnboundPredicateto use virtual inheritance ofExpressionto facilitate visitor pattern.ExpressionVisitorandBoundVisitor.Binder,IsBoundVisitorandRewriteNot.Closes #70 #71 #72