Skip to content

feat: add UUID representation#242

Merged
Fokko merged 8 commits into
apache:mainfrom
zhjwpku:uuid
Sep 29, 2025
Merged

feat: add UUID representation#242
Fokko merged 8 commits into
apache:mainfrom
zhjwpku:uuid

Conversation

@zhjwpku

@zhjwpku zhjwpku commented Sep 23, 2025

Copy link
Copy Markdown
Collaborator

UUID representation along with utilities such as generators for v4 and v7.

uuid generator for v4 and v7
FromString and ToString utilities
@zhjwpku zhjwpku requested a review from wgtmac September 23, 2025 02:21
Comment thread src/iceberg/util/uuid_util.cc Outdated
Comment thread src/iceberg/util/uuid_util.cc Outdated
Comment thread src/iceberg/util/uuid_util.h Outdated
Comment thread src/iceberg/util/uuid_util.cc Outdated
Comment thread src/iceberg/util/uuid_util.cc Outdated
Comment thread src/iceberg/util/uuid_util.cc Outdated
@zhjwpku zhjwpku changed the title feat: add uuid utils feat: add UUID representation Sep 24, 2025
@zhjwpku zhjwpku requested review from HeartLinked, lidavidm, mapleFU and wgtmac and removed request for HeartLinked and mapleFU September 24, 2025 15:19
Comment thread src/iceberg/util/uuid.cc Outdated
Comment thread src/iceberg/util/uuid.h Outdated
Comment thread src/iceberg/util/uuid.h
Comment thread src/iceberg/util/uuid.h
Comment thread src/iceberg/util/uuid.h
Comment thread src/iceberg/util/uuid.cc
Comment thread src/iceberg/util/uuid.cc Outdated
Comment thread src/iceberg/util/uuid.cc Outdated
@zhjwpku zhjwpku requested a review from wgtmac September 28, 2025 06:57
Comment thread src/iceberg/util/uuid.h Outdated

@mapleFU mapleFU left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General LGTM

Comment thread src/iceberg/util/uuid.cc Outdated
Comment thread src/iceberg/util/uuid.cc Outdated
@zhjwpku

zhjwpku commented Sep 28, 2025

Copy link
Copy Markdown
Collaborator Author

Hi @Fokko @zeroshade @Xuanwo , this PR is ready for merge, I'd appreciate if you can take a look when available, thanks.

@Fokko Fokko merged commit a89b101 into apache:main Sep 29, 2025
7 checks passed
@Fokko

Fokko commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

Looks good @zhjwpku, thanks for working on this, and thanks @mapleFU @wgtmac @HuaHuaY and @HeartLinked for the review!

@zhjwpku zhjwpku deleted the uuid branch October 12, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants