feat: scaffolding work for expression#177
Merged
Merged
Conversation
wgtmac
commented
Aug 15, 2025
wgtmac
commented
Member
- Add interface for term, unbound, bound, reference, predicate, etc.
- Add factory to create expressions.
wgtmac
force-pushed
the
expression
branch
2 times, most recently
from
0bd5939 to
ca00452
Compare
mapleFU
reviewed
Aug 15, 2025
mapleFU
reviewed
Aug 15, 2025
wgtmac
force-pushed
the
expression
branch
2 times, most recently
from
c1c25e7 to
b86dda1
Compare
mapleFU
reviewed
Aug 18, 2025
wgtmac
force-pushed
the
expression
branch
6 times, most recently
from
17bd1f8 to
5a49c08
Compare
Member
Author
|
This PR is ready for review. It looks pretty similar to the Java equivalent. Let me know what you think. @dongxiao1198 @lidavidm @mapleFU @yingcai-cy @zhjwpku |
zhjwpku
approved these changes
Aug 20, 2025
dongxiao1198
approved these changes
Aug 21, 2025
mapleFU
reviewed
Aug 21, 2025
gty404
approved these changes
Aug 21, 2025
mapleFU
reviewed
Aug 23, 2025
mapleFU
reviewed
Aug 23, 2025
mapleFU
approved these changes
Aug 23, 2025
mapleFU
approved these changes
Aug 25, 2025
45 tasks
Member
Author
|
@lidavidm Do you have any comment about this PR? |
zeroshade
requested changes
Sep 23, 2025
Comment on lines
+176
to
+178
| case Expression::Operation::kTrue: | ||
| case Expression::Operation::kFalse: | ||
| case Expression::Operation::kNot: |
Member
There was a problem hiding this comment.
shouldn't there be negations for these?
Member
Author
There was a problem hiding this comment.
Member
Author
|
@zeroshade Thanks for your review! I think I've addressed all your comments. Please check. |
Fokko
reviewed
Oct 7, 2025
Comment on lines
+182
to
+183
| case Expression::Operation::kAnd: | ||
| case Expression::Operation::kOr: |
Contributor
There was a problem hiding this comment.
This is interesting, we can negate and and or through the Morgan's law
Fokko
approved these changes
Oct 7, 2025
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
This looks like a great start! Thanks for working on this @wgtmac, and thanks @zeroshade, @dongxiao1198, @zhjwpku, @mapleFU, @gty404 for the reviews 🙌
Member
Author
|
Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.