Skip to content

[cdc-connector][sqlserver][tests] Fix UT errors by correcting right output#2864

Merged
leonardBang merged 1 commit into
apache:masterfrom
loserwang1024:fix-sqlserver-test
Dec 19, 2023
Merged

[cdc-connector][sqlserver][tests] Fix UT errors by correcting right output#2864
leonardBang merged 1 commit into
apache:masterfrom
loserwang1024:fix-sqlserver-test

Conversation

@loserwang1024

@loserwang1024 loserwang1024 commented Dec 13, 2023

Copy link
Copy Markdown
Contributor

As shown in #2853, SqlServer incremental source cannot support exactly-once now.

Between the time that a change is committed in the source table, and the time that the change appears in the corresponding change table, there is always a small latency interval.

Because the time is random, the test com.ververica.cdc.connectors.sqlserver.source.SqlServerSourceITCase#testEnableBackfillWithDMLPreHighWaterMark will sometime fail even sleep for 5 minute.

however, it's rather than tricky, may not be fixed recently. In oder to not influence other PR's CI , before #2853 is fixed, fix UT errors by correcting right output which includes duplicate data.

@loserwang1024

loserwang1024 commented Dec 13, 2023

Copy link
Copy Markdown
Contributor Author

@gong @leonardBang @GOODBOY008 , CC, before we fix #2853, fix the CI not to block other PR.

@gong gong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loserwang1024

Copy link
Copy Markdown
Contributor Author

@leonardBang , @GOODBOY008 , CC

@leonardBang leonardBang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@leonardBang
leonardBang merged commit 2c557c6 into apache:master Dec 19, 2023
@leonardBang

Copy link
Copy Markdown
Contributor

Thanks @loserwang1024 and @gong for the contribution, LGTM. Let's track this issue in #2853

lvyanquan pushed a commit that referenced this pull request Jan 18, 2024
joyCurry30 pushed a commit to joyCurry30/flink-cdc-connectors that referenced this pull request Mar 22, 2024
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants