[cdc-common] Introduce PIPELINE_LOCAL_TIME_ZONE which help handle time zone well#2797
Merged
Merged
Conversation
ruanhang1993
reviewed
Dec 2, 2023
ruanhang1993
left a comment
ruanhang1993
left a comment
Contributor
There was a problem hiding this comment.
Where is getLocalTimeZone invoked?
Contributor
Author
When we deal TIMESTAMP_LTZ type in Sink |
Contributor
Author
|
@lvyanquan @PatrickRen @Jiabao-Sun Would you like to help review this PR? |
leonardBang
force-pushed
the
sessiont_timezone_config
branch
from
December 3, 2023 04:21
50a4c99 to
942a8dc
Compare
lvyanquan
reviewed
Dec 3, 2023
leonardBang
force-pushed
the
sessiont_timezone_config
branch
from
December 3, 2023 14:59
942a8dc to
be2deae
Compare
Contributor
Author
|
Thanks @PatrickRen and @lvyanquan for the insight, I've simplify the PR, appreciate if you can take a look |
lvyanquan
reviewed
Dec 4, 2023
| context.getConfiguration().get(ValuesDataSinkOptions.PRINT_ENABLED)); | ||
| context.getPipelineConfiguration() | ||
| .get(ValuesDataSinkOptions.MATERIALIZED_IN_MEMORY), | ||
| context.getPipelineConfiguration().get(ValuesDataSinkOptions.PRINT_ENABLED)); |
Contributor
There was a problem hiding this comment.
context.getFactoryConfiguration().
Contributor
There was a problem hiding this comment.
And please fix the code style check failure. Thanks.
adress comments
leonardBang
changed the title
Contributor
Author
|
The failed tests is note related to this PR, merging... |
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
… help handle time zone well (apache#2797) This closes apache#2797.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[cdc-common] Introduce PIPELINE_LOCAL_TIME_ZONE which help handle time zone well