Skip to content

[fix](binlog) Fix nullable type mismatch for timestamp column in _fill_binlog_columns#64495

Open
heguanhui wants to merge 1 commit into
apache:masterfrom
heguanhui:fix/fix-binlog-timestamp-nullable-cast
Open

[fix](binlog) Fix nullable type mismatch for timestamp column in _fill_binlog_columns#64495
heguanhui wants to merge 1 commit into
apache:masterfrom
heguanhui:fix/fix-binlog-timestamp-nullable-cast

Conversation

@heguanhui

@heguanhui heguanhui commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: #64494

Problem Summary:

When running GroupRowsetWriterTest.sub_writer_rollback, a coredump occurs
because assert_cast<ColumnNullable*> fails - the timestamp column is not
wrapped as ColumnNullable in unit test environment.

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@heguanhui heguanhui force-pushed the fix/fix-binlog-timestamp-nullable-cast branch from 38f205e to b931828 Compare June 15, 2026 03:05
@heguanhui

heguanhui commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@heguanhui heguanhui force-pushed the fix/fix-binlog-timestamp-nullable-cast branch from b931828 to ab8383c Compare June 15, 2026 03:17
@heguanhui

heguanhui commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

/review

@heguanhui heguanhui force-pushed the fix/fix-binlog-timestamp-nullable-cast branch from ab8383c to cbd6622 Compare June 15, 2026 03:20
@heguanhui

heguanhui commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@heguanhui heguanhui mentioned this pull request Jun 15, 2026
Open
16 tasks
@hello-stephen

hello-stephen commented Jun 15, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 29011 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cbd6622ac26d04f06deeae3d3e84673df6cf03e9, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17610	4039	3986	3986
q2	q3	10843	1361	796	796
q4	4686	482	339	339
q5	7524	883	622	622
q6	177	169	134	134
q7	774	824	641	641
q8	9415	1633	1578	1578
q9	5745	4517	4497	4497
q10	6803	1829	1527	1527
q11	430	270	252	252
q12	625	432	289	289
q13	18154	3354	2760	2760
q14	262	257	241	241
q15	q16	814	787	715	715
q17	961	897	978	897
q18	6958	5760	5596	5596
q19	1340	1258	1048	1048
q20	512	397	261	261
q21	5984	2532	2597	2532
q22	432	358	300	300
Total cold run time: 100049 ms
Total hot run time: 29011 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4335	4260	4237	4237
q2	q3	4484	4989	4365	4365
q4	2082	2197	1366	1366
q5	4410	4281	4318	4281
q6	228	172	127	127
q7	1738	1616	1488	1488
q8	2910	2258	2196	2196
q9	8098	8205	8007	8007
q10	4865	4767	4296	4296
q11	602	428	380	380
q12	737	787	552	552
q13	3280	3691	2995	2995
q14	285	291	269	269
q15	q16	714	753	626	626
q17	1347	1319	1350	1319
q18	8005	7336	7372	7336
q19	1184	1119	1109	1109
q20	2212	2216	1933	1933
q21	5232	4550	4459	4459
q22	512	465	418	418
Total cold run time: 57260 ms
Total hot run time: 51759 ms

@hello-stephen

hello-stephen commented Jun 15, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 168890 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cbd6622ac26d04f06deeae3d3e84673df6cf03e9, data reload: false

query5	4322	607	464	464
query6	438	187	172	172
query7	4860	549	305	305
query8	375	213	197	197
query9	10155	4203	4139	4139
query10	464	313	252	252
query11	5885	2378	2185	2185
query12	160	105	99	99
query13	1398	600	409	409
query14	7421	5300	4986	4986
query14_1	4315	4333	4354	4333
query15	209	195	174	174
query16	1011	445	385	385
query17	1088	685	555	555
query18	2558	453	329	329
query19	195	187	136	136
query20	111	106	102	102
query21	225	131	113	113
query22	13608	13615	13413	13413
query23	17470	16568	16085	16085
query23_1	16288	16275	16287	16275
query24	7494	1752	1292	1292
query24_1	1325	1324	1317	1317
query25	574	468	393	393
query26	1292	312	168	168
query27	2689	533	344	344
query28	4428	2040	2017	2017
query29	1072	625	488	488
query30	305	236	200	200
query31	1133	1072	964	964
query32	107	61	58	58
query33	533	324	258	258
query34	1169	1146	653	653
query35	750	775	690	690
query36	1390	1420	1260	1260
query37	153	103	92	92
query38	3186	3170	3028	3028
query39	923	915	930	915
query39_1	898	879	873	873
query40	225	123	102	102
query41	80	66	68	66
query42	94	91	94	91
query43	322	319	274	274
query44	
query45	195	184	180	180
query46	1088	1217	741	741
query47	2373	2446	2280	2280
query48	407	399	306	306
query49	632	470	361	361
query50	1028	362	286	286
query51	4380	4311	4263	4263
query52	86	86	75	75
query53	240	267	187	187
query54	256	205	187	187
query55	77	77	69	69
query56	224	211	217	211
query57	1430	1412	1351	1351
query58	231	208	199	199
query59	1560	1664	1403	1403
query60	265	247	217	217
query61	150	143	148	143
query62	695	653	595	595
query63	227	178	184	178
query64	2495	745	618	618
query65	
query66	1771	455	341	341
query67	29725	29632	28927	28927
query68	
query69	417	292	257	257
query70	1004	977	932	932
query71	300	219	206	206
query72	2920	2622	2341	2341
query73	847	831	424	424
query74	5178	4974	4776	4776
query75	2654	2589	2237	2237
query76	2298	1119	770	770
query77	345	362	274	274
query78	12449	12365	11906	11906
query79	1397	1080	731	731
query80	601	461	403	403
query81	455	275	241	241
query82	561	156	117	117
query83	335	269	254	254
query84	
query85	868	523	413	413
query86	356	306	285	285
query87	3368	3405	3161	3161
query88	3617	2735	2695	2695
query89	424	383	323	323
query90	1879	181	178	178
query91	172	155	133	133
query92	62	59	55	55
query93	1402	1418	822	822
query94	558	350	290	290
query95	666	462	340	340
query96	1109	758	342	342
query97	2691	2710	2570	2570
query98	213	206	199	199
query99	1156	1179	1036	1036
Total cold run time: 252785 ms
Total hot run time: 168890 ms

@heguanhui heguanhui force-pushed the fix/fix-binlog-timestamp-nullable-cast branch from cbd6622 to a88f7f0 Compare June 15, 2026 08:44
@heguanhui

heguanhui commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jun 15, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 29078 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a88f7f0e4773274464dac033377260eb16b49392, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17695	4063	4015	4015
q2	q3	10747	1419	784	784
q4	4690	476	345	345
q5	7604	867	588	588
q6	181	169	133	133
q7	792	839	635	635
q8	9332	1545	1622	1545
q9	5938	4570	4564	4564
q10	6815	1812	1528	1528
q11	427	262	246	246
q12	636	426	287	287
q13	18149	3404	2775	2775
q14	261	258	247	247
q15	q16	830	775	702	702
q17	1006	926	911	911
q18	7023	5846	5613	5613
q19	1286	1310	1136	1136
q20	527	410	256	256
q21	5875	2549	2453	2453
q22	425	352	315	315
Total cold run time: 100239 ms
Total hot run time: 29078 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4367	4279	4280	4279
q2	q3	4515	4979	4346	4346
q4	2096	2203	1384	1384
q5	4444	4330	4344	4330
q6	229	174	129	129
q7	1763	1611	1775	1611
q8	2722	2246	2217	2217
q9	8263	8367	8011	8011
q10	4829	4792	4351	4351
q11	566	407	373	373
q12	781	748	546	546
q13	3306	3643	2992	2992
q14	302	292	291	291
q15	q16	705	729	636	636
q17	1342	1311	1303	1303
q18	7992	7386	7276	7276
q19	1190	1131	1132	1131
q20	2232	2206	1948	1948
q21	5292	4571	4459	4459
q22	512	458	395	395
Total cold run time: 57448 ms
Total hot run time: 52008 ms

@hello-stephen

hello-stephen commented Jun 15, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 167940 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a88f7f0e4773274464dac033377260eb16b49392, data reload: false

query5	4369	615	466	466
query6	443	192	174	174
query7	4831	526	307	307
query8	370	209	194	194
query9	8757	3976	3996	3976
query10	452	313	260	260
query11	5906	2379	2131	2131
query12	165	102	96	96
query13	1274	596	391	391
query14	6384	5355	5038	5038
query14_1	4370	4363	4336	4336
query15	208	192	176	176
query16	1054	469	421	421
query17	1100	688	559	559
query18	2487	460	335	335
query19	198	177	136	136
query20	115	112	104	104
query21	212	136	120	120
query22	13594	13585	13479	13479
query23	17398	16602	16178	16178
query23_1	16355	16326	16240	16240
query24	7895	1748	1295	1295
query24_1	1286	1305	1309	1305
query25	580	456	406	406
query26	1315	314	169	169
query27	2671	566	342	342
query28	4481	2041	1988	1988
query29	1122	608	464	464
query30	321	229	196	196
query31	1093	1052	946	946
query32	103	57	56	56
query33	504	307	249	249
query34	1160	1121	642	642
query35	742	783	671	671
query36	1381	1401	1236	1236
query37	152	99	89	89
query38	3192	3145	3046	3046
query39	923	913	898	898
query39_1	880	871	889	871
query40	223	121	98	98
query41	63	59	58	58
query42	93	92	93	92
query43	316	317	276	276
query44	
query45	191	187	175	175
query46	1054	1184	735	735
query47	2385	2414	2231	2231
query48	419	410	287	287
query49	627	457	346	346
query50	929	336	248	248
query51	4367	4419	4308	4308
query52	85	85	75	75
query53	247	265	192	192
query54	261	214	189	189
query55	80	76	71	71
query56	233	230	222	222
query57	1429	1395	1340	1340
query58	228	214	204	204
query59	1518	1637	1426	1426
query60	270	253	224	224
query61	154	153	151	151
query62	705	655	586	586
query63	230	183	181	181
query64	2602	735	585	585
query65	
query66	1814	458	341	341
query67	29132	29011	29532	29011
query68	
query69	425	306	256	256
query70	925	988	913	913
query71	292	218	197	197
query72	2859	2600	2375	2375
query73	855	727	412	412
query74	5138	4942	4767	4767
query75	2674	2567	2237	2237
query76	2331	1128	778	778
query77	346	384	293	293
query78	12480	12358	11958	11958
query79	1259	1051	774	774
query80	554	487	400	400
query81	459	285	238	238
query82	242	165	124	124
query83	299	275	255	255
query84	
query85	910	582	490	490
query86	321	317	293	293
query87	3427	3358	3195	3195
query88	3618	2774	2724	2724
query89	409	394	331	331
query90	2228	183	179	179
query91	189	174	189	174
query92	61	59	54	54
query93	1491	1467	865	865
query94	555	360	320	320
query95	671	377	433	377
query96	1042	790	368	368
query97	2674	2715	2560	2560
query98	225	205	200	200
query99	1138	1170	1012	1012
Total cold run time: 249898 ms
Total hot run time: 167940 ms

@heguanhui heguanhui force-pushed the fix/fix-binlog-timestamp-nullable-cast branch from a88f7f0 to b0e16f7 Compare June 15, 2026 12:48
@heguanhui

heguanhui commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jun 15, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 28976 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b0e16f74e0e84889ec651eb4a34535373ac3bbb4, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17884	4192	4145	4145
q2	q3	10748	1444	843	843
q4	4679	473	348	348
q5	7525	879	587	587
q6	190	175	140	140
q7	764	840	650	650
q8	9356	1716	1601	1601
q9	6047	4550	4488	4488
q10	6767	1807	1483	1483
q11	437	279	247	247
q12	642	425	303	303
q13	18147	3422	2725	2725
q14	262	261	248	248
q15	q16	825	772	708	708
q17	851	845	979	845
q18	6909	5661	5521	5521
q19	1293	1277	1045	1045
q20	521	394	262	262
q21	5956	2653	2476	2476
q22	438	359	311	311
Total cold run time: 100241 ms
Total hot run time: 28976 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4413	4325	4505	4325
q2	q3	4506	4978	4365	4365
q4	2094	2196	1375	1375
q5	4474	4295	4324	4295
q6	224	176	136	136
q7	1732	1638	1906	1638
q8	2685	2297	2291	2291
q9	8202	8459	8030	8030
q10	4875	4796	4375	4375
q11	577	426	383	383
q12	767	761	578	578
q13	3305	3636	3058	3058
q14	299	313	278	278
q15	q16	726	723	627	627
q17	1360	1316	1343	1316
q18	7887	7199	7145	7145
q19	1189	1154	1152	1152
q20	2221	2215	1956	1956
q21	5276	4595	4443	4443
q22	521	457	462	457
Total cold run time: 57333 ms
Total hot run time: 52223 ms

@hello-stephen

hello-stephen commented Jun 15, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 170077 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b0e16f74e0e84889ec651eb4a34535373ac3bbb4, data reload: false

query5	4321	631	478	478
query6	447	194	176	176
query7	4848	564	308	308
query8	386	220	211	211
query9	8765	4122	4138	4122
query10	441	313	264	264
query11	5903	2355	2151	2151
query12	157	105	99	99
query13	1259	610	447	447
query14	6399	5452	5167	5167
query14_1	4491	4398	4394	4394
query15	210	193	176	176
query16	1006	449	441	441
query17	1071	688	559	559
query18	2495	473	341	341
query19	195	190	146	146
query20	111	107	104	104
query21	215	138	123	123
query22	13756	13693	13505	13505
query23	17408	16558	16111	16111
query23_1	16243	16311	16229	16229
query24	7469	1766	1323	1323
query24_1	1305	1317	1300	1300
query25	558	437	373	373
query26	1306	334	169	169
query27	2643	584	343	343
query28	4432	2077	2065	2065
query29	1111	609	479	479
query30	311	238	200	200
query31	1112	1066	955	955
query32	112	57	56	56
query33	509	317	252	252
query34	1176	1196	667	667
query35	756	797	692	692
query36	1380	1385	1232	1232
query37	150	104	91	91
query38	3233	3157	3034	3034
query39	934	921	896	896
query39_1	892	872	887	872
query40	223	127	100	100
query41	64	61	62	61
query42	96	93	95	93
query43	335	332	287	287
query44	
query45	191	182	186	182
query46	1123	1258	752	752
query47	2378	2361	2217	2217
query48	410	412	298	298
query49	628	479	344	344
query50	985	362	260	260
query51	4350	4284	4216	4216
query52	89	89	76	76
query53	241	283	188	188
query54	272	211	203	203
query55	83	75	70	70
query56	249	225	210	210
query57	1443	1417	1317	1317
query58	239	215	211	211
query59	1623	1685	1472	1472
query60	281	256	237	237
query61	160	169	179	169
query62	709	657	589	589
query63	239	195	196	195
query64	2605	845	679	679
query65	
query66	1844	476	358	358
query67	29785	29772	29512	29512
query68	
query69	459	320	283	283
query70	1000	970	952	952
query71	302	235	228	228
query72	3229	2830	2411	2411
query73	857	780	435	435
query74	5132	4963	4806	4806
query75	2658	2609	2227	2227
query76	2302	1174	805	805
query77	359	382	292	292
query78	12423	12490	12015	12015
query79	1419	1093	775	775
query80	1264	463	378	378
query81	502	290	257	257
query82	594	169	124	124
query83	333	283	250	250
query84	
query85	899	515	412	412
query86	417	309	290	290
query87	3447	3377	3211	3211
query88	3723	2775	2734	2734
query89	425	388	341	341
query90	1934	187	190	187
query91	176	159	130	130
query92	62	61	55	55
query93	1538	1436	907	907
query94	667	353	297	297
query95	690	380	357	357
query96	1106	814	361	361
query97	2694	2652	2551	2551
query98	244	202	209	202
query99	1146	1230	1038	1038
Total cold run time: 252569 ms
Total hot run time: 170077 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei Awaiting requested review from yiguolei

@liaoxin01 liaoxin01 Awaiting requested review from liaoxin01

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

@eldenmoon eldenmoon Awaiting requested review from eldenmoon

@csun5285 csun5285 Awaiting requested review from csun5285

@airborne12 airborne12 Awaiting requested review from airborne12

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@heguanhui @hello-stephen