Skip to content

[fix](case) fix insert_group_commit_into_max_filter_ratio#64402

Merged
morningman merged 1 commit into
apache:masterfrom
mymeiyi:fix-insert_group_commit_into_max_filter_ratio
Jun 15, 2026
Merged

[fix](case) fix insert_group_commit_into_max_filter_ratio#64402
morningman merged 1 commit into
apache:masterfrom
mymeiyi:fix-insert_group_commit_into_max_filter_ratio

Conversation

@mymeiyi

@mymeiyi mymeiyi commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 11, 2026 06:31
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mymeiyi

mymeiyi commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the regression test insert_group_commit_into_max_filter_ratio to use enable_strict_cast in the JDBC insert section and adjusts the expected minimum row count for the async visibility wait.

Changes:

  • Explicitly sets enable_strict_cast in the JDBC connect block (toggle false → true → false around a cast-failure insert).
  • Replaces a strict-insert toggle (enable_insert_strict = true) with enable_strict_cast = true for the cast failure scenario.
  • Lowers the get_row_count_with_retry(...) threshold from 8 to 7.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mymeiyi

mymeiyi commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary for PR 64402

Overall opinion: no additional blocking issue found beyond the existing inline threads already opened on this PR. The change is a focused regression-test fix: it makes the cast-failure case use enable_strict_cast and aligns the async wait threshold with the seven rows recorded in insert_group_commit_into_max_filter_ratio.out.

Critical checkpoint conclusions:

  • Goal/test proof: The goal appears to be fixing this regression case strict-cast/session-variable behavior and expected async row count. The changed expected count is consistent with the generated .out rows: 1, 2, 3, 4, 5, 7, and 9. I did not run the regression suite locally; GitHub-side checks visible now pass except TeamCity compile is still queued.
  • Scope: Small and focused; one regression test file, no production path changes.
  • Concurrency, lifecycle, config, compatibility, persistence, protocol: Not applicable; no runtime code, config item, storage format, FE-BE protocol, or persistence change is introduced.
  • Parallel paths: Stream-load and http-stream sections in the same suite remain unchanged, and their row-count checks match the existing expected output.
  • Test correctness: Existing review threads already cover two robustness gaps: the strict-cast try/catch should fail when no exception occurs, and get_row_count_with_retry should assert after retries. I did not add duplicate inline comments for those already-known issues. I found no separate new test-output mismatch.
  • Observability/performance: Not applicable for this test-only change; no meaningful runtime observability or performance impact.
  • User focus: review_focus.txt contains no additional user-provided focus points.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit 3534b85 into apache:master Jun 15, 2026
34 checks passed
yiguolei pushed a commit that referenced this pull request Jun 16, 2026
…64402 (#64528)

Cherry-picked from #64402

Co-authored-by: meiyi <meiyi@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x dev/4.1.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants