Skip to content

[feature](variable) enables views, materialized views, generated columns, and alias functions to persist session variables#58031

Merged
morrySnow merged 58 commits into
apache:masterfrom
feiniaofeiafei:variable_fix
Dec 5, 2025
Merged

[feature](variable) enables views, materialized views, generated columns, and alias functions to persist session variables#58031
morrySnow merged 58 commits into
apache:masterfrom
feiniaofeiafei:variable_fix

Conversation

@feiniaofeiafei

@feiniaofeiafei feiniaofeiafei commented Nov 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
When creating views, generated columns, materialized views, or alias functions, session variables that affect query results (e.g., enable_decimal256) are not persisted. This causes inconsistent query results when session variables differ between creation and query time.

This PR persists session variables marked with affectQueryResult() annotation for:

  • Views
  • Generated Columns
  • Materialized Views
  • Alias Functions

When querying these objects, the system automatically uses the persisted session variables from creation time, ensuring consistent results.

Key Changes

  • Added sessionVariables field to View, Column, MTMV, and AliasFunction classes
  • Created AutoCloseSessionVariable utility to temporarily apply persisted variables during query processing
  • Modified view/column/MV/function parsing logic to use persisted session variables
  • Added SessionVarGuardExpr to protect expressions that depend on session variables

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@feiniaofeiafei feiniaofeiafei marked this pull request as draft November 14, 2025 08:53
@feiniaofeiafei

feiniaofeiafei commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Nov 14, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 33958 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ace5df2043d4f7cfefd3741080041a20ffefa53f, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17584	5243	5065	5065
q2	2023	310	201	201
q3	10323	1290	732	732
q4	10239	939	380	380
q5	7472	2378	2437	2378
q6	191	165	135	135
q7	915	807	635	635
q8	9360	1401	1119	1119
q9	7050	5173	5166	5166
q10	6894	2198	1801	1801
q11	506	298	290	290
q12	377	368	233	233
q13	17787	3710	3082	3082
q14	228	240	215	215
q15	q16	997	1000	973	973
q17	606	865	376	376
q18	7838	7229	7061	7061
q19	1083	952	570	570
q20	363	341	230	230
q21	4122	3305	2347	2347
q22	1063	1023	969	969
Total cold run time: 107021 ms
Total hot run time: 33958 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	5184	5141	5142	5141
q2	259	331	234	234
q3	2206	2711	2305	2305
q4	1404	1844	1353	1353
q5	4239	4438	4516	4438
q6	212	176	129	129
q7	2106	1901	1979	1901
q8	2741	2600	2596	2596
q9	7386	7224	7224	7224
q10	3076	3328	2779	2779
q11	580	532	514	514
q12	738	800	641	641
q13	3580	4039	3407	3407
q14	298	301	294	294
q15	q16	1089	1132	1068	1068
q17	1218	1536	1481	1481
q18	7797	7730	7426	7426
q19	765	795	916	795
q20	1894	2020	1792	1792
q21	4852	4437	4266	4266
q22	1101	1037	997	997
Total cold run time: 52725 ms
Total hot run time: 50781 ms

@doris-robot

doris-robot commented Nov 14, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 180135 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ace5df2043d4f7cfefd3741080041a20ffefa53f, data reload: false

customer_demographics	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:43:56	2023-12-26 22:44:34	NULL	utf-8	NULL	NULL	
promotion	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:43:58	2023-12-26 22:44:01	NULL	utf-8	NULL	NULL	
web_page	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:43:59	2023-12-26 22:44:01	NULL	utf-8	NULL	NULL	
store_returns	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:43:59	2023-12-26 22:47:09	NULL	utf-8	NULL	NULL	
income_band	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:43:58	2023-12-26 22:44:01	NULL	utf-8	NULL	NULL	
dbgen_version	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:44:00	2023-12-26 22:44:01	NULL	utf-8	NULL	NULL	
catalog_page	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:43:58	2023-12-26 22:44:01	NULL	utf-8	NULL	NULL	
reason	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:43:56	2023-12-26 22:44:01	NULL	utf-8	NULL	NULL	
============================================
query1	1009	427	400	400
query2	6562	1733	1657	1657
query3	6768	232	225	225
query4	26424	23762	23381	23381
query5	4418	630	471	471
query6	335	228	222	222
query7	query8	301	268	248	248
query9	9489	2590	2599	2590
query10	598	350	301	301
query11	15702	15347	14968	14968
query12	185	123	122	122
query13	query14	11200	9321	9377	9321
query15	211	216	195	195
query16	7187	686	539	539
query17	query18	2103	430	350	350
query19	231	208	195	195
query20	135	127	126	126
query21	221	130	119	119
query22	query23	34084	32883	33049	32883
query24	10784	2438	2424	2424
query25	727	558	482	482
query26	query27	query28	7333	2222	2201	2201
query29	query30	304	233	203	203
query31	925	818	704	704
query32	123	75	71	71
query33	794	386	346	346
query34	1506	845	522	522
query35	808	855	788	788
query36	933	1003	907	907
query37	216	117	88	88
query38	3495	3575	3411	3411
query39	query40	235	136	130	130
query41	77	67	69	67
query42	124	114	118	114
query43	492	509	487	487
query44	1262	777	750	750
query45	186	196	184	184
query46	896	1009	650	650
query47	1797	1836	1707	1707
query48	616	434	337	337
query49	874	509	433	433
query50	631	692	409	409
query51	3974	3914	4021	3914
query52	117	110	103	103
query53	228	267	192	192
query54	314	287	273	273
query55	88	85	87	85
query56	341	325	312	312
query57	1188	1203	1120	1120
query58	297	283	287	283
query59	2497	2682	2569	2569
query60	340	360	344	344
query61	169	161	158	158
query62	821	728	660	660
query63	229	196	203	196
query64	5211	1203	865	865
query65	4009	3968	3942	3942
query66	1207	431	330	330
query67	15347	15129	15201	15129
query68	8366	928	605	605
query69	494	306	291	291
query70	1324	1199	1260	1199
query71	463	343	319	319
query72	6763	4986	4910	4910
query73	661	634	362	362
query74	9089	8876	8721	8721
query75	3608	3331	2797	2797
query76	3479	1146	721	721
query77	737	413	314	314
query78	9591	9877	8930	8930
query79	1054	816	646	646
query80	653	597	497	497
query81	505	257	228	228
query82	634	160	137	137
query83	266	269	258	258
query84	255	111	97	97
query85	query86	340	331	295	295
query87	3709	3709	3665	3665
query88	2889	2263	2235	2235
query89	386	322	303	303
query90	2266	222	216	216
query91	171	167	138	138
query92	81	73	65	65
query93	1156	978	647	647
query94	773	442	359	359
query95	413	332	314	314
query96	483	576	288	288
query97	2981	2987	2867	2867
query98	242	213	216	213
query99	1398	1430	1295	1295
Total cold run time: 263908 ms
Total hot run time: 180135 ms

@feiniaofeiafei

feiniaofeiafei commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

run buildall

1 similar comment
@feiniaofeiafei

feiniaofeiafei commented Nov 17, 2025

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 64.03% (308/481) 🎉
Increment coverage report
Complete coverage report

@doris-robot

doris-robot commented Nov 17, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 33798 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 81556aae730ee604b94e68090cbb86ce2d240d89, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17581	5128	5018	5018
q2	2039	335	208	208
q3	10295	1276	723	723
q4	10223	935	371	371
q5	7490	2490	2345	2345
q6	181	164	135	135
q7	934	764	638	638
q8	9357	1368	1191	1191
q9	7081	5161	5231	5161
q10	6913	2232	1836	1836
q11	506	307	274	274
q12	375	368	228	228
q13	17784	3660	3038	3038
q14	236	233	220	220
q15	q16	978	986	961	961
q17	605	882	376	376
q18	7493	7339	7022	7022
q19	1091	972	549	549
q20	370	339	231	231
q21	3976	3284	2304	2304
q22	1072	1035	969	969
Total cold run time: 106580 ms
Total hot run time: 33798 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	5066	5072	5103	5072
q2	245	323	237	237
q3	2161	2696	2280	2280
q4	1351	1796	1356	1356
q5	4238	4284	4472	4284
q6	222	175	135	135
q7	2025	1980	1784	1784
q8	2733	2598	2578	2578
q9	7448	7319	7298	7298
q10	3141	3240	2865	2865
q11	594	514	492	492
q12	713	819	636	636
q13	3539	3912	3523	3523
q14	281	303	279	279
q15	q16	1046	1104	1046	1046
q17	1193	1479	1474	1474
q18	7947	7623	7719	7623
q19	826	836	909	836
q20	2047	2177	1921	1921
q21	4903	4339	4313	4313
q22	1074	1063	985	985
Total cold run time: 52793 ms
Total hot run time: 51017 ms

@doris-robot

doris-robot commented Nov 17, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 181914 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 81556aae730ee604b94e68090cbb86ce2d240d89, data reload: false

customer_demographics	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:43:56	2023-12-26 22:44:34	NULL	utf-8	NULL	NULL	
promotion	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:43:58	2023-12-26 22:44:01	NULL	utf-8	NULL	NULL	
web_page	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:43:59	2023-12-26 22:44:01	NULL	utf-8	NULL	NULL	
store_returns	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:43:59	2023-12-26 22:47:09	NULL	utf-8	NULL	NULL	
income_band	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:43:58	2023-12-26 22:44:01	NULL	utf-8	NULL	NULL	
dbgen_version	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:44:00	2023-12-26 22:44:01	NULL	utf-8	NULL	NULL	
catalog_page	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:43:58	2023-12-26 22:44:01	NULL	utf-8	NULL	NULL	
reason	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:43:56	2023-12-26 22:44:01	NULL	utf-8	NULL	NULL	
============================================
query1	1027	441	396	396
query2	6556	1680	1713	1680
query3	6753	240	227	227
query4	26654	24449	23527	23527
query5	4391	641	522	522
query6	350	246	222	222
query7	query8	308	267	248	248
query9	9384	2959	2989	2959
query10	577	347	325	325
query11	15782	15538	14832	14832
query12	186	130	132	130
query13	query14	11966	9332	9381	9332
query15	222	206	186	186
query16	7402	699	538	538
query17	query18	2128	465	341	341
query19	217	208	178	178
query20	137	126	125	125
query21	213	129	112	112
query22	query23	33915	32890	32986	32890
query24	10426	2435	2445	2435
query25	728	519	473	473
query26	query27	query28	7317	2327	2281	2281
query29	query30	303	220	196	196
query31	947	826	728	728
query32	121	84	84	84
query33	760	395	393	393
query34	1491	847	520	520
query35	803	852	770	770
query36	935	998	927	927
query37	222	116	106	106
query38	3554	3598	3486	3486
query39	query40	232	137	131	131
query41	66	62	61	61
query42	131	116	122	116
query43	465	521	458	458
query44	1303	809	803	803
query45	182	178	170	170
query46	914	1001	680	680
query47	1767	1830	1711	1711
query48	612	472	349	349
query49	786	493	469	469
query50	632	688	402	402
query51	3905	4005	4050	4005
query52	114	111	108	108
query53	244	272	198	198
query54	332	314	306	306
query55	97	102	95	95
query56	339	346	340	340
query57	1168	1188	1135	1135
query58	314	285	287	285
query59	2577	2614	2571	2571
query60	362	364	351	351
query61	168	165	168	165
query62	838	719	655	655
query63	234	206	205	205
query64	5226	1163	896	896
query65	4037	3995	3928	3928
query66	1206	450	361	361
query67	15397	14991	15056	14991
query68	2875	1002	699	699
query69	441	346	310	310
query70	1350	1268	1164	1164
query71	368	356	333	333
query72	6668	5160	5355	5160
query73	559	628	386	386
query74	8862	9231	8782	8782
query75	3261	3245	2796	2796
query76	2482	1124	777	777
query77	419	425	365	365
query78	9597	9685	9080	9080
query79	1875	846	624	624
query80	1857	641	588	588
query81	561	270	241	241
query82	228	166	145	145
query83	425	281	262	262
query84	317	123	104	104
query85	query86	404	329	304	304
query87	3732	3748	3616	3616
query88	2903	2348	2267	2267
query89	382	319	285	285
query90	2048	233	240	233
query91	162	172	137	137
query92	81	73	75	73
query93	1069	1073	703	703
query94	709	416	337	337
query95	428	357	356	356
query96	486	604	293	293
query97	2948	2965	2868	2868
query98	246	225	212	212
query99	1307	1431	1300	1300
Total cold run time: 258473 ms
Total hot run time: 181914 ms

@hello-stephen

hello-stephen commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 76.09% (366/481) 🎉
Increment coverage report
Complete coverage report

@feiniaofeiafei

feiniaofeiafei commented Nov 17, 2025

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Nov 17, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 33656 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d3f14f7a3100bfb6551264067a5cf29e0a357633, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17605	5152	5036	5036
q2	2077	315	216	216
q3	10207	1298	693	693
q4	10236	950	369	369
q5	7540	2396	2379	2379
q6	181	167	136	136
q7	914	781	627	627
q8	9341	1367	1155	1155
q9	7000	5205	5197	5197
q10	6922	2217	1793	1793
q11	497	308	278	278
q12	369	368	230	230
q13	17786	3683	3045	3045
q14	232	226	210	210
q15	q16	1004	994	937	937
q17	599	902	380	380
q18	7983	7066	6955	6955
q19	1099	940	534	534
q20	384	358	227	227
q21	4206	3184	2268	2268
q22	1041	1024	991	991
Total cold run time: 107223 ms
Total hot run time: 33656 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	5136	5120	5019	5019
q2	251	320	231	231
q3	2148	2677	2297	2297
q4	1372	1788	1314	1314
q5	4250	4349	4603	4349
q6	208	170	130	130
q7	2080	2027	1864	1864
q8	2625	2717	2666	2666
q9	7549	7162	7367	7162
q10	2986	3223	2857	2857
q11	595	523	518	518
q12	668	773	625	625
q13	3590	3983	3513	3513
q14	281	291	270	270
q15	q16	1056	1121	1042	1042
q17	1146	1495	1726	1495
q18	7867	7942	7567	7567
q19	847	810	811	810
q20	2008	2120	1940	1940
q21	5048	4717	4491	4491
q22	1161	1133	1054	1054
Total cold run time: 52872 ms
Total hot run time: 51214 ms

@doris-robot

doris-robot commented Nov 17, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 188127 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d3f14f7a3100bfb6551264067a5cf29e0a357633, data reload: false

query1	1028	399	413	399
query2	6558	1712	1684	1684
query3	6760	228	229	228
query4	26994	23467	23024	23024
query5	4998	654	522	522
query6	337	227	241	227
query7	4647	505	316	316
query8	310	256	251	251
query9	8706	2927	2890	2890
query10	522	351	334	334
query11	16044	15141	14885	14885
query12	195	122	117	117
query13	1680	558	444	444
query14	11579	9161	9112	9112
query15	209	187	169	169
query16	7672	640	496	496
query17	1194	769	636	636
query18	2059	425	326	326
query19	210	216	195	195
query20	141	128	122	122
query21	213	132	110	110
query22	4195	4064	3939	3939
query23	33709	33018	32826	32826
query24	8118	2393	2377	2377
query25	611	533	459	459
query26	1242	278	166	166
query27	2740	501	366	366
query28	4439	2292	2270	2270
query29	833	617	497	497
query30	299	227	194	194
query31	898	781	732	732
query32	102	82	77	77
query33	584	390	344	344
query34	797	869	529	529
query35	844	835	778	778
query36	1023	995	902	902
query37	128	124	105	105
query38	3594	3541	3399	3399
query39	1482	1432	1420	1420
query40	229	143	130	130
query41	68	61	62	61
query42	130	120	126	120
query43	478	489	474	474
query44	1263	808	796	796
query45	188	178	175	175
query46	897	1000	642	642
query47	1755	1779	1744	1744
query48	406	422	333	333
query49	763	493	420	420
query50	646	683	405	405
query51	3910	3983	3824	3824
query52	122	124	109	109
query53	244	274	200	200
query54	357	343	332	332
query55	108	101	95	95
query56	383	366	368	366
query57	1173	1198	1131	1131
query58	320	298	296	296
query59	2621	2661	2535	2535
query60	397	383	366	366
query61	194	191	186	186
query62	792	722	677	677
query63	238	208	204	204
query64	4572	1307	1010	1010
query65	4038	3966	3963	3963
query66	1091	492	368	368
query67	15524	15183	14808	14808
query68	7871	949	642	642
query69	507	347	312	312
query70	1335	1290	1192	1192
query71	452	369	350	350
query72	6054	4889	4881	4881
query73	640	583	371	371
query74	8917	9089	8883	8883
query75	3270	3264	2777	2777
query76	3294	1126	748	748
query77	528	418	338	338
query78	9489	9699	8865	8865
query79	2656	817	609	609
query80	652	607	522	522
query81	516	275	233	233
query82	487	164	134	134
query83	275	271	244	244
query84	262	114	92	92
query85	922	479	446	446
query86	393	322	328	322
query87	3586	3633	3549	3549
query88	3836	2237	2220	2220
query89	399	330	298	298
query90	2008	238	226	226
query91	165	168	137	137
query92	98	80	75	75
query93	2040	996	696	696
query94	733	440	328	328
query95	414	341	332	332
query96	482	586	281	281
query97	2912	2973	2866	2866
query98	260	230	215	215
query99	1375	1399	1306	1306
Total cold run time: 277429 ms
Total hot run time: 188127 ms

@doris-robot

doris-robot commented Nov 17, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 27.61 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d3f14f7a3100bfb6551264067a5cf29e0a357633, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.26	0.08	0.08
query4	1.61	0.11	0.10
query5	0.27	0.25	0.25
query6	1.21	0.65	0.64
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.58	0.52	0.51
query10	0.57	0.57	0.58
query11	0.16	0.12	0.11
query12	0.16	0.12	0.12
query13	0.62	0.61	0.60
query14	1.00	1.00	1.00
query15	0.85	0.83	0.83
query16	0.38	0.39	0.38
query17	1.00	1.03	1.05
query18	0.21	0.19	0.20
query19	1.91	1.82	1.81
query20	0.02	0.02	0.02
query21	15.49	0.18	0.13
query22	5.18	0.06	0.04
query23	15.67	0.26	0.10
query24	3.02	0.55	0.98
query25	0.07	0.06	0.06
query26	0.14	0.12	0.15
query27	0.06	0.05	0.05
query28	5.25	1.16	1.01
query29	12.72	3.86	3.16
query30	0.30	0.14	0.11
query31	2.82	0.56	0.38
query32	3.23	0.56	0.46
query33	3.05	3.09	3.06
query34	15.81	5.18	4.56
query35	4.57	4.59	4.58
query36	0.70	0.51	0.49
query37	0.10	0.07	0.07
query38	0.06	0.05	0.04
query39	0.04	0.03	0.02
query40	0.17	0.14	0.13
query41	0.08	0.04	0.03
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 99.65 s
Total hot run time: 27.61 s

@feiniaofeiafei

feiniaofeiafei commented Nov 17, 2025

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Nov 17, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 34165 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9d69b21761c5e5d977c17bd93a62d867743154ac, data reload: false

------ Round 1 ----------------------------------
q1	18234	5158	5072	5072
q2	2044	336	207	207
q3	10210	1280	729	729
q4	10229	943	379	379
q5	7470	2373	2346	2346
q6	188	164	136	136
q7	931	754	610	610
q8	9326	1335	1104	1104
q9	6855	5085	5125	5085
q10	6812	2257	1836	1836
q11	489	303	273	273
q12	329	363	220	220
q13	17759	3636	3053	3053
q14	224	231	208	208
q15	564	517	507	507
q16	1015	994	947	947
q17	575	887	372	372
q18	7419	7101	7048	7048
q19	1083	944	544	544
q20	350	344	233	233
q21	3731	3243	2288	2288
q22	1067	1035	968	968
Total cold run time: 106904 ms
Total hot run time: 34165 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5135	5109	5093	5093
q2	248	327	238	238
q3	2187	2667	2291	2291
q4	1366	1819	1290	1290
q5	4265	4458	4663	4458
q6	208	176	142	142
q7	2069	1924	1881	1881
q8	2688	2638	2625	2625
q9	7449	7003	7453	7003
q10	3032	3212	2823	2823
q11	592	530	505	505
q12	683	772	653	653
q13	3470	4031	3369	3369
q14	301	292	278	278
q15	569	500	582	500
q16	1191	1121	1054	1054
q17	1169	1578	1385	1385
q18	8104	7651	7602	7602
q19	785	772	840	772
q20	2029	2100	1917	1917
q21	4978	4523	4496	4496
q22	1084	1035	997	997
Total cold run time: 53602 ms
Total hot run time: 51372 ms

@doris-robot

doris-robot commented Nov 17, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 188856 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9d69b21761c5e5d977c17bd93a62d867743154ac, data reload: false

query1	1014	402	384	384
query2	6572	1728	1718	1718
query3	6769	228	225	225
query4	26507	23802	22985	22985
query5	4826	673	541	541
query6	327	238	231	231
query7	4656	502	312	312
query8	300	258	242	242
query9	8664	2920	2924	2920
query10	519	337	304	304
query11	15819	15133	14983	14983
query12	178	125	119	119
query13	1676	553	459	459
query14	11131	9438	9445	9438
query15	202	197	170	170
query16	7705	647	520	520
query17	1213	803	656	656
query18	2041	443	351	351
query19	218	211	191	191
query20	141	133	128	128
query21	217	134	117	117
query22	3928	4047	3933	3933
query23	34045	33178	33021	33021
query24	8123	2463	2440	2440
query25	649	560	503	503
query26	1244	285	178	178
query27	2723	501	360	360
query28	4410	2283	2252	2252
query29	834	662	533	533
query30	300	232	194	194
query31	925	801	723	723
query32	99	84	82	82
query33	606	411	369	369
query34	793	869	521	521
query35	851	867	755	755
query36	977	999	921	921
query37	134	118	105	105
query38	3575	3617	3517	3517
query39	1472	1398	1391	1391
query40	238	142	129	129
query41	69	66	66	66
query42	139	124	119	119
query43	486	471	471	471
query44	1291	816	809	809
query45	190	201	176	176
query46	900	998	653	653
query47	1758	1823	1694	1694
query48	418	435	322	322
query49	763	498	418	418
query50	649	682	412	412
query51	3821	3873	3920	3873
query52	117	117	109	109
query53	247	276	214	214
query54	328	313	300	300
query55	95	98	91	91
query56	345	349	351	349
query57	1177	1191	1095	1095
query58	299	296	291	291
query59	2502	2598	2486	2486
query60	362	372	354	354
query61	167	162	157	157
query62	821	720	689	689
query63	229	206	199	199
query64	4521	1249	902	902
query65	4075	3951	3977	3951
query66	1112	443	348	348
query67	15220	15081	14877	14877
query68	8337	965	643	643
query69	498	339	308	308
query70	1338	1278	1295	1278
query71	501	361	330	330
query72	5823	4959	4936	4936
query73	712	598	377	377
query74	9111	9133	8609	8609
query75	3941	3212	2813	2813
query76	3769	1136	762	762
query77	812	418	346	346
query78	9479	9711	8849	8849
query79	2187	819	617	617
query80	693	639	540	540
query81	491	273	248	248
query82	429	168	139	139
query83	268	273	251	251
query84	254	117	92	92
query85	920	483	455	455
query86	344	314	318	314
query87	3656	3727	3606	3606
query88	3362	2266	2245	2245
query89	426	337	307	307
query90	2030	242	232	232
query91	178	177	138	138
query92	96	76	76	76
query93	1557	1012	684	684
query94	697	462	332	332
query95	421	352	343	343
query96	492	582	285	285
query97	2954	2935	2861	2861
query98	249	224	214	214
query99	1435	1393	1280	1280
Total cold run time: 276182 ms
Total hot run time: 188856 ms

@doris-robot

doris-robot commented Nov 17, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 27.65 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9d69b21761c5e5d977c17bd93a62d867743154ac, data reload: false

query1	0.06	0.05	0.06
query2	0.10	0.05	0.04
query3	0.25	0.08	0.08
query4	1.61	0.11	0.11
query5	0.27	0.25	0.25
query6	1.19	0.63	0.65
query7	0.04	0.02	0.03
query8	0.05	0.04	0.04
query9	0.58	0.53	0.51
query10	0.58	0.57	0.57
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.64	0.61	0.60
query14	1.01	1.01	0.98
query15	0.84	0.84	0.82
query16	0.39	0.38	0.39
query17	1.00	1.03	0.99
query18	0.21	0.20	0.20
query19	1.92	1.77	1.85
query20	0.02	0.02	0.02
query21	15.44	0.21	0.13
query22	4.96	0.06	0.04
query23	15.68	0.25	0.09
query24	2.56	0.90	0.74
query25	0.07	0.06	0.06
query26	0.14	0.13	0.13
query27	0.06	0.05	0.05
query28	4.69	1.16	0.95
query29	12.58	3.96	3.30
query30	0.28	0.14	0.11
query31	2.82	0.57	0.37
query32	3.24	0.56	0.48
query33	3.01	3.03	3.02
query34	15.78	5.15	4.53
query35	4.57	4.60	4.51
query36	0.66	0.50	0.50
query37	0.09	0.06	0.06
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.13	0.14
query41	0.10	0.03	0.03
query42	0.04	0.04	0.03
query43	0.04	0.03	0.04
Total cold run time: 98.16 s
Total hot run time: 27.65 s

@hello-stephen

hello-stephen commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 79.70% (373/468) 🎉
Increment coverage report
Complete coverage report

@feiniaofeiafei

feiniaofeiafei commented Nov 19, 2025

Copy link
Copy Markdown
Contributor Author

run buildall

1 similar comment
@feiniaofeiafei

feiniaofeiafei commented Nov 19, 2025

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Nov 19, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 34060 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e41186468e3dc5ea4aa14f7c318aefc2d094671d, data reload: false

------ Round 1 ----------------------------------
q1	17581	5084	4929	4929
q2	2105	326	221	221
q3	10219	1301	727	727
q4	10231	903	354	354
q5	7480	2351	2351	2351
q6	183	170	137	137
q7	924	751	618	618
q8	9333	1399	1145	1145
q9	7110	5294	5432	5294
q10	6831	2220	1802	1802
q11	485	293	280	280
q12	346	370	235	235
q13	17780	3663	3018	3018
q14	242	235	211	211
q15	565	509	504	504
q16	1049	996	926	926
q17	586	878	359	359
q18	7313	7139	6950	6950
q19	1220	961	551	551
q20	355	337	228	228
q21	3718	3169	2234	2234
q22	1038	1028	986	986
Total cold run time: 106694 ms
Total hot run time: 34060 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4977	4986	4953	4953
q2	318	395	327	327
q3	2161	2653	2318	2318
q4	1353	1730	1328	1328
q5	4191	4299	4560	4299
q6	217	169	133	133
q7	2009	1961	1832	1832
q8	2652	2672	2624	2624
q9	7641	7662	7609	7609
q10	3149	3223	2850	2850
q11	593	542	533	533
q12	658	799	628	628
q13	3536	3883	3278	3278
q14	290	404	373	373
q15	531	505	501	501
q16	1106	1099	1044	1044
q17	1169	1497	1341	1341
q18	8159	7849	7654	7654
q19	829	782	861	782
q20	2104	2128	1977	1977
q21	4934	4727	4282	4282
q22	1075	1047	1029	1029
Total cold run time: 53652 ms
Total hot run time: 51695 ms

@doris-robot

doris-robot commented Nov 19, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 187928 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e41186468e3dc5ea4aa14f7c318aefc2d094671d, data reload: false

query1	1029	402	394	394
query2	6582	1690	1708	1690
query3	6757	237	224	224
query4	26101	23363	23014	23014
query5	4472	660	525	525
query6	371	263	253	253
query7	4661	502	308	308
query8	307	287	257	257
query9	8703	2974	2965	2965
query10	499	356	310	310
query11	15485	14941	14767	14767
query12	182	123	121	121
query13	1691	576	465	465
query14	10929	9081	9104	9081
query15	198	186	173	173
query16	7762	657	474	474
query17	1327	755	623	623
query18	2029	417	326	326
query19	219	199	177	177
query20	142	132	128	128
query21	220	133	117	117
query22	3985	4024	3911	3911
query23	33970	32989	32920	32920
query24	8137	2386	2380	2380
query25	601	540	469	469
query26	1240	277	165	165
query27	2730	493	366	366
query28	4393	2284	2238	2238
query29	802	626	500	500
query30	335	224	198	198
query31	895	817	698	698
query32	92	80	79	79
query33	584	393	345	345
query34	765	853	528	528
query35	792	820	782	782
query36	952	1030	931	931
query37	131	119	98	98
query38	3570	3574	3450	3450
query39	1467	1433	1420	1420
query40	228	144	127	127
query41	63	61	60	60
query42	131	117	116	116
query43	495	493	470	470
query44	1275	814	804	804
query45	188	181	172	172
query46	895	986	645	645
query47	1748	1816	1769	1769
query48	394	436	317	317
query49	764	492	421	421
query50	654	679	407	407
query51	3858	3915	3836	3836
query52	117	122	119	119
query53	249	270	203	203
query54	337	322	308	308
query55	94	99	92	92
query56	352	352	345	345
query57	1190	1197	1126	1126
query58	302	292	294	292
query59	2433	2629	2488	2488
query60	368	368	346	346
query61	186	161	152	152
query62	792	708	655	655
query63	237	200	204	200
query64	4515	1160	873	873
query65	4074	3934	3947	3934
query66	1120	438	343	343
query67	15560	14959	14740	14740
query68	5448	997	650	650
query69	523	342	299	299
query70	1333	1294	1224	1224
query71	440	354	314	314
query72	5805	5068	5193	5068
query73	651	608	372	372
query74	8980	8789	8915	8789
query75	3255	3235	2831	2831
query76	3330	1135	735	735
query77	542	421	356	356
query78	9564	9839	8863	8863
query79	1377	959	632	632
query80	1716	609	534	534
query81	552	264	232	232
query82	417	162	143	143
query83	360	266	258	258
query84	251	113	98	98
query85	910	510	457	457
query86	391	331	326	326
query87	3726	3677	3582	3582
query88	2833	2273	2222	2222
query89	380	335	309	309
query90	1746	241	232	232
query91	170	166	136	136
query92	85	85	76	76
query93	1160	1028	683	683
query94	720	430	324	324
query95	441	353	343	343
query96	488	599	279	279
query97	2899	2934	2840	2840
query98	243	242	217	217
query99	1269	1411	1274	1274
Total cold run time: 269731 ms
Total hot run time: 187928 ms

@doris-robot

doris-robot commented Nov 19, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 27.66 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e41186468e3dc5ea4aa14f7c318aefc2d094671d, data reload: false

query1	0.06	0.04	0.04
query2	0.10	0.06	0.05
query3	0.26	0.09	0.08
query4	1.60	0.11	0.11
query5	0.27	0.25	0.26
query6	1.19	0.66	0.65
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.58	0.52	0.52
query10	0.57	0.58	0.57
query11	0.16	0.11	0.11
query12	0.14	0.11	0.12
query13	0.62	0.59	0.60
query14	1.01	1.00	0.99
query15	0.85	0.83	0.85
query16	0.39	0.40	0.38
query17	0.99	1.06	1.02
query18	0.24	0.20	0.20
query19	1.89	1.86	1.85
query20	0.02	0.01	0.01
query21	15.45	0.19	0.14
query22	5.07	0.07	0.05
query23	15.70	0.25	0.11
query24	2.51	0.63	0.84
query25	0.07	0.06	0.06
query26	0.14	0.13	0.13
query27	0.06	0.05	0.05
query28	4.74	1.14	0.94
query29	12.55	3.88	3.20
query30	0.28	0.14	0.12
query31	2.82	0.59	0.40
query32	3.23	0.55	0.47
query33	3.03	3.03	3.08
query34	15.70	5.23	4.49
query35	4.55	4.57	4.62
query36	0.67	0.51	0.49
query37	0.09	0.06	0.06
query38	0.07	0.04	0.05
query39	0.03	0.03	0.03
query40	0.17	0.14	0.14
query41	0.08	0.03	0.02
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 98.12 s
Total hot run time: 27.66 s

@feiniaofeiafei

feiniaofeiafei commented Nov 19, 2025

Copy link
Copy Markdown
Contributor Author

run cloud_p0

@hello-stephen

hello-stephen commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 79.51% (419/527) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow changed the title [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [feature](variable) enables views, materialized views, generated columns, and alias functions to persist session variables Dec 4, 2025
morningman
morningman approved these changes Dec 4, 2025
View reviewed changes

@morningman morningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen

hello-stephen commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 90.26% (454/503) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.17% (24750/34292)
Line Coverage 58.87% (259696/441141)
Region Coverage 53.74% (215546/401081)
Branch Coverage 55.23% (92073/166702)

@hello-stephen

hello-stephen commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 81.55% (535/656) 🎉
Increment coverage report
Complete coverage report

seawinde
seawinde approved these changes Dec 5, 2025
View reviewed changes

@seawinde seawinde left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow morrySnow merged commit c1eec85 into apache:master Dec 5, 2025
42 of 48 checks passed
feiniaofeiafei added a commit to feiniaofeiafei/doris that referenced this pull request Dec 8, 2025
@feiniaofeiafei @jacktengg
[feature](variable) enables views, materialized views, generated colu…
e85f5e6 
…mns, and alias functions to persist session variables (apache#58031)

Problem Summary:
When creating views, generated columns, materialized views, or alias
functions, session variables that affect query results (e.g.,
`enable_decimal256`) are not persisted. This causes inconsistent query
results when session variables differ between creation and query time.

This PR persists session variables marked with `affectQueryResult()`
annotation for:
- Views
- Generated Columns
- Materialized Views
- Alias Functions

When querying these objects, the system automatically uses the persisted
session variables from creation time, ensuring consistent results.

- Added `sessionVariables` field to `View`, `Column`, `MTMV`, and
`AliasFunction` classes
- Created `AutoCloseSessionVariable` utility to temporarily apply
persisted variables during query processing
- Modified view/column/MV/function parsing logic to use persisted
session variables
- Added `SessionVarGuardExpr` to protect expressions that depend on
session variables

---------

Co-authored-by: jacktengg <tengjianping@selectdb.com>
@feiniaofeiafei feiniaofeiafei mentioned this pull request Dec 8, 2025
Merged
@seawinde seawinde mentioned this pull request Dec 9, 2025
Merged
16 tasks
@feiniaofeiafei feiniaofeiafei mentioned this pull request Dec 9, 2025
Merged
16 tasks
feiniaofeiafei added a commit to feiniaofeiafei/doris that referenced this pull request Dec 11, 2025
@feiniaofeiafei @jacktengg
[feature](variable) enables views, materialized views, generated colu…
5106e97 
…mns, and alias functions to persist session variables (apache#58031)

Problem Summary:
When creating views, generated columns, materialized views, or alias
functions, session variables that affect query results (e.g.,
`enable_decimal256`) are not persisted. This causes inconsistent query
results when session variables differ between creation and query time.

This PR persists session variables marked with `affectQueryResult()`
annotation for:
- Views
- Generated Columns
- Materialized Views
- Alias Functions

When querying these objects, the system automatically uses the persisted
session variables from creation time, ensuring consistent results.

- Added `sessionVariables` field to `View`, `Column`, `MTMV`, and
`AliasFunction` classes
- Created `AutoCloseSessionVariable` utility to temporarily apply
persisted variables during query processing
- Modified view/column/MV/function parsing logic to use persisted
session variables
- Added `SessionVarGuardExpr` to protect expressions that depend on
session variables

---------

Co-authored-by: jacktengg <tengjianping@selectdb.com>
feiniaofeiafei added a commit to feiniaofeiafei/doris that referenced this pull request Dec 11, 2025
@feiniaofeiafei @jacktengg
[feature](variable) enables views, materialized views, generated colu…
87ff5b4 
…mns, and alias functions to persist session variables (apache#58031)

Problem Summary:
When creating views, generated columns, materialized views, or alias
functions, session variables that affect query results (e.g.,
`enable_decimal256`) are not persisted. This causes inconsistent query
results when session variables differ between creation and query time.

This PR persists session variables marked with `affectQueryResult()`
annotation for:
- Views
- Generated Columns
- Materialized Views
- Alias Functions

When querying these objects, the system automatically uses the persisted
session variables from creation time, ensuring consistent results.

- Added `sessionVariables` field to `View`, `Column`, `MTMV`, and
`AliasFunction` classes
- Created `AutoCloseSessionVariable` utility to temporarily apply
persisted variables during query processing
- Modified view/column/MV/function parsing logic to use persisted
session variables
- Added `SessionVarGuardExpr` to protect expressions that depend on
session variables

---------

Co-authored-by: jacktengg <tengjianping@selectdb.com>
yiguolei pushed a commit that referenced this pull request Dec 12, 2025
@feiniaofeiafei @jacktengg
branch4.0: [feature](variable) enables views, materialized views, gen…
b37b8b6 
…erated columns, and alias functions to persist session variables #58031 (#58821)

picked from #58031

---------

Co-authored-by: jacktengg <tengjianping@selectdb.com>
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@feiniaofeiafei @jacktengg @nagisa-kunhah
[feature](variable) enables views, materialized views, generated colu…
4e12587 
…mns, and alias functions to persist session variables (apache#58031)

### What problem does this PR solve?

Problem Summary:
When creating views, generated columns, materialized views, or alias
functions, session variables that affect query results (e.g.,
`enable_decimal256`) are not persisted. This causes inconsistent query
results when session variables differ between creation and query time.

This PR persists session variables marked with `affectQueryResult()`
annotation for:
- Views
- Generated Columns  
- Materialized Views
- Alias Functions

When querying these objects, the system automatically uses the persisted
session variables from creation time, ensuring consistent results.

#### Key Changes

- Added `sessionVariables` field to `View`, `Column`, `MTMV`, and
`AliasFunction` classes
- Created `AutoCloseSessionVariable` utility to temporarily apply
persisted variables during query processing
- Modified view/column/MV/function parsing logic to use persisted
session variables
- Added `SessionVarGuardExpr` to protect expressions that depend on
session variables

---------


Co-authored-by: jacktengg <tengjianping@selectdb.com>
@feiniaofeiafei feiniaofeiafei mentioned this pull request Dec 15, 2025
Merged
16 tasks
hello-stephen pushed a commit that referenced this pull request Dec 16, 2025
@feiniaofeiafei
[fix](test) fix case test_array_agg_view use same table in a database (…
f2619bd 
…#59027)

Related PR: #58031
github-actions Bot pushed a commit that referenced this pull request Dec 16, 2025
@feiniaofeiafei
[fix](test) fix case test_array_agg_view use same table in a database (…
0fae966 
…#59027)

Related PR: #58031
morrySnow pushed a commit that referenced this pull request Jan 7, 2026
@seawinde
[test](mtmv) Add ut test for session variable guard when generate mt…
f1b6e16 
…mv cache (#58863)

mtmvCache is globally reused, and each query shares the same instance of
mtmvCache. When generating the cache, it should not include any
attributes that are specific to an individual query.
current code has no problem, just add some ut

Related PR: #58031
github-actions Bot pushed a commit that referenced this pull request Jan 7, 2026
@seawinde
[test](mtmv) Add ut test for session variable guard when generate mt…
c87eb8e 
…mv cache (#58863)

mtmvCache is globally reused, and each query shares the same instance of
mtmvCache. When generating the cache, it should not include any
attributes that are specific to an individual query.
current code has no problem, just add some ut

Related PR: #58031
zzzxl1993 pushed a commit to zzzxl1993/doris that referenced this pull request Jan 13, 2026
@seawinde @zzzxl1993
[test](mtmv) Add ut test for session variable guard when generate mt…
1d0333b 
…mv cache (apache#58863)

mtmvCache is globally reused, and each query shares the same instance of
mtmvCache. When generating the cache, it should not include any
attributes that are specific to an individual query.
current code has no problem, just add some ut

Related PR: apache#58031
@yiguolei yiguolei mentioned this pull request Jan 23, 2026
Open
@seawinde seawinde mentioned this pull request Mar 30, 2026
Closed
16 tasks
@jacktengg jacktengg mentioned this pull request Jun 15, 2026
Open
16 tasks
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Jun 16, 2026
@jacktengg
[improvement](fe) Rewrite nullif to if expression
3dbefbc 
Problem Summary: FunctionIf in BE is only reached through nullif because SQL if is rewritten to VectorizedIfExpr. The nullif semantics can be represented as if(first = second, null, first), so this adds a Nereids expression normalization rule to rewrite remaining NullIf expressions to If after existing constant folding. The nullable-dependent conditional simplification also falls back to the same rewrite so NullIf does not survive that path.

Rewriting nullif to if must not be controlled by disable_nereids_expression_rules, otherwise users could disable the rewrite and still require BE FunctionIf support for nullif. This changes NullIfToIf from a pattern rule with an ExpressionRuleType bit into a direct visitor-based expression rewrite rule, and adds coverage that the rewrite still runs when all expression rule bits are disabled.

Alse delete stale file be/src/exprs/function/function_ifnull.h which is deleted by apache#58125 but accidentally add back by apache#58031
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Jun 16, 2026
@jacktengg
[improvement](fe) Rewrite nullif to if expression
262455c 
 Problem Summary: BE FunctionIf is only needed by the legacy nullif execution path because SQL if()
  has already been rewritten to VectorizedIfExpr. The nullif expression is semantically equivalent to
  if(first = second, null, first), so Nereids now rewrites ordinary builtin nullif(first, second)
  calls in LogicalPlanBuilder before function binding and expression rewrite rules run. This makes the
  rewrite unconditional and independent of disable_nereids_expression_rules, while preserving normal
  analysis for non-builtin or invalid forms such as qualified names, DISTINCT, window specs, hints,
  and wrong arity.

Alse delete stale file be/src/exprs/function/function_ifnull.h which is deleted by apache#58125 but accidentally add back by apache#58031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@924060929 924060929 924060929 approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

@morrySnow morrySnow morrySnow approved these changes

@seawinde seawinde seawinde approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

@CalvinKirs CalvinKirs Awaiting requested review from CalvinKirs CalvinKirs is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@feiniaofeiafei @hello-stephen @doris-robot @jacktengg @seawinde @morningman @924060929 @zclllyybb @morrySnow @yiguolei