Parser: fix exponential parse time on compound keyword chains#2350
Open
LucaCappelletti94 wants to merge 3 commits into
Open
Parser: fix exponential parse time on compound keyword chains#2350LucaCappelletti94 wants to merge 3 commits into
LucaCappelletti94 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same family as #2344 and #2349. A reserved keyword in field position (e.g.
NOTin.not-b.not-b...) drivesparse_prefix->parse_not->parse_subexpr, re-walking the chain at every segment and doubling the work. The result is always rejected (UnaryOp), so the speculation is wasted, andparse_identifierin the existing None branch produces the sameIdentifierdirectly. The solution I identified is to skip the speculativeparse_prefixinparse_compound_exprwhen the next token is aWordnot followed by(. Surfaced by subql fuzzing on a 527 B input that took 2.65 s and now takes 270 us.