Hive: Support MAP<K, V> column types#2346
Conversation
|
|
||
| #[test] | ||
| fn parse_create_table_with_map_column_comment() { | ||
| let sql = "create table tmp.xxx (kv_map map<string, string> comment 'kv col comment');"; |
There was a problem hiding this comment.
can we have the test only do a round trip test via verified_stmt?
There was a problem hiding this comment.
In hive, the map<string, string> and map(string, string) are not exactly the same, is there a need to change the notation from ( to <, for hive separately?
There was a problem hiding this comment.
I don't think we necessarily need to, the impl is ok if we're happy with the current roundtrip behavior, my comment was primarily around the test setup, if verified_stmt does not apply to the syntax then an alternative will be one_statement_parse_to where we pass the input sql and expected canonical sql to assert
There was a problem hiding this comment.
I've rethought it, converting map<string, string> to map(string, string) in the hive dialect will cause the parsed sql to fail compilation, which is a functionality breaker, it's better to keep the logic of the sql before and after consistent. (
2 participants
close: #2345